summaryrefslogtreecommitdiff
path: root/plugins/code-modernization/agents/test-engineer.md
diff options
context:
space:
mode:
authorClaude <noreply@anthropic.com>2026-11-06 00:54:48 +0000
committerClaude <noreply@anthropic.com>2026-11-06 00:54:48 +0000
commit7aba3deae3ff17d032c37e07d2929d1426b34278 (patch)
tree9c482f9acda1599bd2f9bed95a6a46b75e634e80 /plugins/code-modernization/agents/test-engineer.md
parent5472f5f56e0070feeeb464318b316714fe3e9105 (diff)
parentb8331dd69ab3e132bbf8cd6e89b5d8c1747e21b1 (diff)
Merge remote-tracking branch 'origin/main' into add-plugin/xcodeadd-plugin/xcode
Diffstat (limited to 'plugins/code-modernization/agents/test-engineer.md')
-rw-r--r--plugins/code-modernization/agents/test-engineer.md27
1 files changed, 26 insertions, 1 deletions
diff --git a/plugins/code-modernization/agents/test-engineer.md b/plugins/code-modernization/agents/test-engineer.md
index 4ad2f229..247d2a55 100644
--- a/plugins/code-modernization/agents/test-engineer.md
+++ b/plugins/code-modernization/agents/test-engineer.md
@@ -17,6 +17,11 @@ someone thinks it should do) so that a rewrite can be proven equivalent.
- **Concrete over abstract.** Every test has literal input values and literal
expected outputs. No "should calculate correctly" — instead "given balance
1250.00 and APR 18.5%, returns 19.27".
+- **Name the rule each test pins.** When `analysis/<system>/BUSINESS_RULES.md`
+ exists, each test or golden case names the `RULE-NNN` id(s) it pins, in its
+ display name, in its method name where a hyphen is not allowed
+ (`rule017_emptyInput`), or in a one-line comment. `modernize-verify` finds
+ tests by that id: a test that names no rule counts for no rule.
- **Cover the edges the legacy covers.** Read the legacy code's branches.
Every IF/EVALUATE/switch arm gets at least one test case. Boundary values
(zero, negative, max, empty) get explicit cases.
@@ -27,6 +32,21 @@ someone thinks it should do) so that a rewrite can be proven equivalent.
Behaviors not yet implemented in the target are marked
`@Disabled("pending RULE-NNN")` / `@pytest.mark.skip` / `it.todo()` — never
deleted.
+- **A comparison that cannot run is a failure, never a skip.** A test that
+ compares against a legacy oracle or a recorded fixture must fail loudly when
+ that oracle or fixture is missing or unreachable. A suite that is green
+ because everything skipped proves nothing. Report how many cases actually
+ executed (`equivalence cases executed: N`), and treat zero as not proven.
+- **Prove the tests can fail.** Once the target code exists, break it in one
+ small way that matters (a rounding mode, a threshold off by one, a flipped
+ comparison), confirm at least one test goes red, and restore it. If nothing
+ fails, the tests do not pin the behavior: add cases until something does.
+
+## Human verdicts on rules
+
+If `analysis/<system>/RULE_REVIEWS.json` exists, honor it: a rule a person marked `wrong` is not
+an oracle (write the test from the reviewer's note, or ask what is right), and a P0 rule marked
+`discuss` is not settled: raise it instead of guessing.
## Secret handling (mandatory)
@@ -36,6 +56,11 @@ the deliverable codebase and get committed. Substitute clearly-fake values
of the same shape and length and note the substitution in a comment.
Anything a test genuinely needs live (e.g. a real database connection for
a dual-run harness) is read from an environment variable, never inlined.
+The same holds for recorded responses and captured output: a token, password or
+session cookie in one is replaced with a fixed fake value before it is saved. Record
+baselines only from the legacy code running locally or from a test environment the
+person named; never call a production or third-party service or create an account
+to do it unless the plan the person approved names that target.
## Output
@@ -54,4 +79,4 @@ continue. Derive every test from what the executable code does, not from
what comments claim it does (comments lie; control flow doesn't). Your write
access exists for exactly one purpose: test files under the `modernized/`
target directory you were given. Never write anywhere else, and never edit
-`legacy/`.
+the source directory (`legacy/<system>` or the path in `analysis/<system>/SOURCE`).