diff options
| author | Morgan Lunt <morganl@anthropic.com> | 2026-05-11 16:46:03 -0700 |
|---|---|---|
| committer | Morgan Lunt <morganl@anthropic.com> | 2026-05-11 16:46:03 -0700 |
| commit | 5e4a45001d608ce34437181d96340faa1f5899c9 (patch) | |
| tree | bc7c7793c38957f6bb2a656c359e1e755cfba2fd /plugins/code-modernization/commands | |
| parent | 22a1b2597750246f104c88e66f0c379932d05c9b (diff) | |
code-modernization: harden writes a patch instead of editing legacy; make map/security guidance language-agnosticmorganl/code-modernization-plugin
- modernize-harden: never edits legacy/ anymore. Writes findings plus a
reviewed unified diff to analysis/<system>/security_remediation.patch.
A second security-auditor pass reviews each hunk (RESOLVES / PARTIAL /
INTRODUCES-RISK) before presenting. The user reviews and applies the
patch deliberately, then re-runs to verify. This makes every command
consistent with the recommended deny Edit(legacy/**) workspace setting,
so the README's exception note is gone.
- modernize-map: restructure the parse-target list around three stack-
agnostic principles (dispatcher targets are variables; code-storage
joins live in config; entry points live in deployment descriptors), with
COBOL/Java/web/CLI examples on equal footing rather than COBOL-dominant.
Same protections against false dead-code findings, less stack-specific.
- security-auditor agent: rephrase coverage items in stack-neutral terms
(record layouts/temp datasets, resource ACLs, deployment scripts/job
definitions, batch input records) so the checklist reads naturally for
COBOL, Java EE, .NET, and web targets alike.
- README: drop the harden exception note; describe the patch workflow.
Diffstat (limited to 'plugins/code-modernization/commands')
| -rw-r--r-- | plugins/code-modernization/commands/modernize-harden.md | 58 | ||||
| -rw-r--r-- | plugins/code-modernization/commands/modernize-map.md | 71 |
2 files changed, 76 insertions, 53 deletions
diff --git a/plugins/code-modernization/commands/modernize-harden.md b/plugins/code-modernization/commands/modernize-harden.md index 4ef80cf3..b8f7a72c 100644 --- a/plugins/code-modernization/commands/modernize-harden.md +++ b/plugins/code-modernization/commands/modernize-harden.md @@ -1,23 +1,26 @@ --- -description: Security vulnerability scan + remediation — OWASP, CVE, secrets, injection +description: Security vulnerability scan with a reviewable remediation patch — OWASP, CWE, CVE, secrets, injection argument-hint: <system-dir> --- Run a **security hardening pass** on `legacy/$1`: find vulnerabilities, rank -them, and fix the critical ones. +them, and produce a reviewable patch for the critical ones. + +This command never edits `legacy/` — it writes findings and a proposed patch +to `analysis/$1/`. The user reviews and applies (or not). ## Scan Spawn the **security-auditor** subagent: -"Adversarially audit legacy/$1 for security vulnerabilities. Cover: -OWASP Top 10 (injection, broken auth, XSS, SSRF, etc.), hardcoded secrets, -vulnerable dependency versions (check package manifests against known CVEs), -missing input validation, insecure deserialization, path traversal. -For each finding return: CWE ID, severity (Critical/High/Med/Low), file:line, -one-sentence exploit scenario, and recommended fix. Also run any available -SAST tooling (npm audit, pip-audit, OWASP dependency-check) and include -its raw output." +"Adversarially audit legacy/$1 for security vulnerabilities. Cover what's +relevant to the stack: injection (SQL/NoSQL/OS command/template), broken +auth, sensitive data exposure, access control gaps, insecure deserialization, +hardcoded secrets, vulnerable dependency versions, missing input validation, +path traversal. For each finding return: CWE ID, severity +(Critical/High/Med/Low), file:line, one-sentence exploit scenario, and +recommended fix. Run any available SAST tooling (npm audit, pip-audit, +OWASP dependency-check) and include its raw output." ## Triage @@ -28,19 +31,34 @@ Write `analysis/$1/SECURITY_FINDINGS.md`: ## Remediate -For each **Critical** and **High** finding, fix it directly in the source. -Make minimal, targeted changes. After each fix, add a one-line entry under -"Remediation Log" in SECURITY_FINDINGS.md: finding ID → commit-style summary -of what changed. +For each **Critical** and **High** finding, draft a minimal, targeted fix. +Do **not** edit `legacy/` — write all fixes as a single unified diff to +`analysis/$1/security_remediation.patch`, with a comment line above each +hunk citing the finding ID it addresses (`# SEC-001: parameterize the query`). -Show the cumulative diff: -```bash -git -C legacy/$1 diff -``` +Add a **Remediation Log** section to SECURITY_FINDINGS.md mapping each +finding ID → one-line summary of the proposed fix and the patch hunk that +implements it. ## Verify -Re-run the security-auditor against the patched code to confirm the -Critical/High findings are resolved. Update the scorecard with before/after. +Spawn the **security-auditor** again to **review the patch** against the +original code: + +"Review analysis/$1/security_remediation.patch against legacy/$1. For each +hunk: does it fully remediate the cited finding? Does it introduce new +vulnerabilities or change behavior beyond the fix? Return one verdict per +hunk: RESOLVES / PARTIAL / INTRODUCES-RISK, with a one-line reason." + +Add a **Patch Review** section to SECURITY_FINDINGS.md with the verdicts. +If any hunk is PARTIAL or INTRODUCES-RISK, revise the patch and re-review. + +## Present + +Tell the user the artifacts are ready: +- `analysis/$1/SECURITY_FINDINGS.md` — findings, remediation log, patch review +- `analysis/$1/security_remediation.patch` — review, then apply if appropriate + with `git -C legacy/$1 apply ../../analysis/$1/security_remediation.patch` +- Re-run `/modernize-harden $1` after applying to confirm resolution Suggest: `glow -p analysis/$1/SECURITY_FINDINGS.md` diff --git a/plugins/code-modernization/commands/modernize-map.md b/plugins/code-modernization/commands/modernize-map.md index 3a88f49c..406b74c0 100644 --- a/plugins/code-modernization/commands/modernize-map.md +++ b/plugins/code-modernization/commands/modernize-map.md @@ -11,39 +11,44 @@ connect? This is the map an engineer needs before touching anything. ## What to produce Write a one-off analysis script (Python or shell — your choice) that parses -the source under `legacy/$1` and extracts the four datasets below. Cover -the parse targets that are real for the stack you're looking at — these are -the ones LLMs reliably miss: - -- **Program/module call graph** — who calls whom. - - COBOL/CICS: `CALL '...'` and `EXEC CICS LINK/XCTL PROGRAM(...)`. Most - `PROGRAM(...)` targets are **data-names, not literals** — resolve them - against working-storage `VALUE` clauses and any menu/route copybooks - before declaring an edge unresolvable. - - Java: class-level imports/invocations. Node: `require`/`import`. -- **Data dependency graph** — which programs read/write which data stores. - - COBOL batch: `SELECT ... ASSIGN TO <ddname>` joined with JCL `DD` - statements (this is the *only* way to attribute file I/O to a program). - - COBOL/CICS online: `EXEC CICS READ/WRITE/REWRITE/DELETE/STARTBR/READNEXT/ - READPREV ... FILE(...)` joined with `DEFINE FILE` in the CSD. - - DB2: `EXEC SQL ... END-EXEC` table references — *not* JCL DD; DB2 access - is via plan/package binds. - - BMS: `SEND MAP`/`RECEIVE MAP` ↔ map source under `bms/` and copybooks - under `cpy-bms/` (or wherever the maps live). - - Java: JPA/MyBatis entities & tables. Node: model files. -- **Entry points** — whatever the stack's outermost invokers are. Mainframe: - JCL `EXEC PGM=` steps **and** CICS `DEFINE TRANSACTION ... PROGRAM(...)` - from the CSD — without the CSD, every online program looks unreachable. - Web: HTTP routes. CLI: argv parsing. -- **Dead-end candidates** — modules with no inbound edges. **Only trust this - once the entry-point and call-edge types above are all in the graph**, and - suppress the dead claim for any module that could be the target of an - unresolved dynamic call. A naive grep-only graph will mark most CICS - programs dead. - -For COBOL fixed-format, slice columns 8-72 and skip `*` indicator lines -(column 7) before regex matching, or you'll match sequence numbers and -commented-out code. +the source under `legacy/$1` and extracts the four datasets below. Three +principles apply across stacks; getting them wrong produces a misleading map: + +1. **Edges live in two places** — direct calls in source, *and* dispatcher/ + router calls whose targets are variables (config tables, route maps, + dependency injection, dynamic dispatch). Resolve variables against config + before declaring an edge unresolvable. +2. **The code↔storage join is usually external configuration**, not source — + job/deployment descriptors map logical names to physical stores. +3. **Entry points usually live in deployment config**, not source — without + parsing it, every top-level module looks unreachable. + +Extract: + +- **Program/module call graph** — direct calls (`CALL`, method invocations, + `import`/`require`) *and* dispatcher calls (`EXEC CICS LINK/XCTL`, DI + container wiring, framework routing, reflection/factory). Resolve variable + call targets against route tables, copybooks, config, or constant pools. +- **Data dependency graph** — which modules read/write which data stores, + joined through the relevant config: `SELECT…ASSIGN TO` ↔ JCL `DD` (batch + COBOL), `EXEC CICS READ/WRITE…FILE()` ↔ CSD `DEFINE FILE` (CICS online), + `EXEC SQL` table refs (embedded SQL), ORM annotations/mappings (Java/.NET), + model files (Node/Python/Ruby). Include UI/screen bindings (BMS maps, JSPs, + templates) — they're dependencies too. +- **Entry points** — whatever the stack's outermost invoker is, read from + where it's defined: JCL `EXEC PGM=` and CICS CSD `DEFINE TRANSACTION` + (mainframe), `web.xml`/route annotations/route files (web), `main()`/argv + parsing (CLI), queue/scheduler subscriptions (event-driven). +- **Dead-end candidates** — modules with no inbound edges. **Only meaningful + once all the entry-point and call-edge types above are in the graph.** + Suppress the dead claim for anything that could be the target of an + unresolved dynamic call. A grep-only graph will mark most dispatcher-driven + modules (CICS programs, Spring controllers, ORM-bound DAOs) dead when they + aren't. + +If the source is fixed-column (COBOL columns 8–72, RPG, etc.), slice the +code area and strip comment lines before regex matching, or you'll match +sequence numbers and commented-out code. Save the script as `analysis/$1/extract_topology.py` (or `.sh`) so it can be re-run and audited. Have it write a machine-readable |
