<feed xmlns='http://www.w3.org/2005/Atom'>
<title>superpowers.git/tests/claude-code/test-executing-plans-scripts.sh, branch dev</title>
<subtitle>Agentic skills framework and development workflow
</subtitle>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/'/>
<entry>
<title>Merge pull request #2606 from obra/fix/2429-sdd-repo-resolution</title>
<updated>2026-11-02T22:01:03+00:00</updated>
<author>
<name>Drew Ritter</name>
<email>drew@ritter.dev</email>
</author>
<published>2026-11-02T22:01:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=2f5dc3b335c05e8e3078c0be056c1001baa6b554'/>
<id>2f5dc3b335c05e8e3078c0be056c1001baa6b554</id>
<content type='text'>
fix(sdd): helpers act on the current directory's repo like git, with -C to override (#2429)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
fix(sdd): helpers act on the current directory's repo like git, with -C to override (#2429)</pre>
</div>
</content>
</entry>
<entry>
<title>fix(sdd): append git's own error line to the no-repo message</title>
<updated>2026-10-23T00:21:52+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@fsck.com</email>
</author>
<published>2026-10-23T00:17:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=8b0eefc87b26530a71f0912af09af023fa3008fc'/>
<id>8b0eefc87b26530a71f0912af09af023fa3008fc</id>
<content type='text'>
sdd-repo ran git with stderr discarded, so every git failure became
"must run from inside the git working tree ... run 'git init'". Where
git refuses a working tree the caller is actually inside (dubious
ownership on another owner's, FAT, network or WSL /mnt/c checkout; git
missing from PATH; the cwd inside .git), that message is false, points
at git init in an existing project, and hides the one line naming the
real fix. dev printed git's fatal, so this was a diagnostic regression.

The shared message stays, and git's first stderr line from whichever
check failed now always follows it as "git said: &lt;line&gt;", with no
per-case branches:

  SDD scripts must run from inside the git working tree ... then rerun.
  git said: fatal: detected dubious ownership in repository at '/r'

Tests: every no-repo assertion now requires the second line (a plain
non-repo dir gives "git said: fatal: not a git repository"), and a new
test simulates dubious ownership with git's GIT_TEST_ASSUME_DIFFERENT_OWNER
knob (no root or second uid needed; it skips if the installed git
ignores the knob).

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sdd-repo ran git with stderr discarded, so every git failure became
"must run from inside the git working tree ... run 'git init'". Where
git refuses a working tree the caller is actually inside (dubious
ownership on another owner's, FAT, network or WSL /mnt/c checkout; git
missing from PATH; the cwd inside .git), that message is false, points
at git init in an existing project, and hides the one line naming the
real fix. dev printed git's fatal, so this was a diagnostic regression.

The shared message stays, and git's first stderr line from whichever
check failed now always follows it as "git said: &lt;line&gt;", with no
per-case branches:

  SDD scripts must run from inside the git working tree ... then rerun.
  git said: fatal: detected dubious ownership in repository at '/r'

Tests: every no-repo assertion now requires the second line (a plain
non-repo dir gives "git said: fatal: not a git repository"), and a new
test simulates dubious ownership with git's GIT_TEST_ASSUME_DIFFERENT_OWNER
knob (no root or second uid needed; it skips if the installed git
ignores the knob).

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(sdd): act on the cwd's working tree only, drop the plan-repo fallback</title>
<updated>2026-10-23T00:21:52+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@fsck.com</email>
</author>
<published>2026-10-22T23:59:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=0d61007ef6a3a0a870f164a37da14b58f3de192a'/>
<id>0d61007ef6a3a0a870f164a37da14b58f3de192a</id>
<content type='text'>
sdd-repo fell back to the plan file's repository when the current
directory was outside any repository. That made the plugin-cache case
silently succeed somewhere: an agent that cd'd into the skill directory
and passed an absolute plan path got whichever checkout that path
pointed into. With the plan in the main checkout (where writing-plans
leaves it) and execution in a linked worktree, that is the #2429
wrong-worktree bug again, with exit 0. A real session (sdd-cwd-eval
sdd-A-5) took exactly this path and only landed in the right place
because its plan path happened to be the worktree's.

The SDD and executing-plans helpers now pick their repository the way
git does: the current directory's working tree, or DIR when given -C
DIR. Outside any working tree, sdd-workspace, task-brief,
review-package, task-start and task-done all stop with the shared
message and write nothing, even when the plan's absolute path is inside
a repository. sdd-repo no longer takes PLAN_FILE, since the plan has no
say.

The two "outside any repository ... uses the plan's repository" tests
and the task-start/task-done fallback tests become assertions that the
shared message comes out and nothing is written, in the cwd or the
plan's repository.

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sdd-repo fell back to the plan file's repository when the current
directory was outside any repository. That made the plugin-cache case
silently succeed somewhere: an agent that cd'd into the skill directory
and passed an absolute plan path got whichever checkout that path
pointed into. With the plan in the main checkout (where writing-plans
leaves it) and execution in a linked worktree, that is the #2429
wrong-worktree bug again, with exit 0. A real session (sdd-cwd-eval
sdd-A-5) took exactly this path and only landed in the right place
because its plan path happened to be the worktree's.

The SDD and executing-plans helpers now pick their repository the way
git does: the current directory's working tree, or DIR when given -C
DIR. Outside any working tree, sdd-workspace, task-brief,
review-package, task-start and task-done all stop with the shared
message and write nothing, even when the plan's absolute path is inside
a repository. sdd-repo no longer takes PLAN_FILE, since the plan has no
say.

The two "outside any repository ... uses the plan's repository" tests
and the task-start/task-done fallback tests become assertions that the
shared message comes out and nothing is written, in the cwd or the
plan's repository.

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(sdd): one no-repo message that puts "run from your working tree" first</title>
<updated>2026-10-23T00:21:52+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@fsck.com</email>
</author>
<published>2026-10-22T23:25:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=de67241e0a8f241b5607f99c3891d5e517e2cf47'/>
<id>de67241e0a8f241b5607f99c3891d5e517e2cf47</id>
<content type='text'>
sdd-repo's no-repository message told every caller to run 'git init'.
That is the right fix for a new project, but the other way to reach it
is standing in the wrong directory, such as the plugin's own skill
directory after reading "from this skill's directory" literally. There,
'git init' would turn the plugin cache into a repository and hide the
real mistake.

task-start and task-done were worse. They still read HEAD and BASE in
the bare cwd while the brief and ledger went through sdd-repo. From a
non-repo cwd with the plan in a repo that has commits, task-start wrote
the brief into the plan's repo, then printed git's fatal plus "HEAD has
no commit yet ... make an initial commit first" and exited 2. task-done
printed git's fatal. review-package in a repo with no commit said
"bad BASE: HEAD~1".

Every helper that can hit this (sdd-workspace, task-brief,
review-package, task-start, task-done) now stops with the same message
from sdd-repo, naming the current directory and offering init-and-commit
only as the new-project case:

  SDD scripts must run from inside the git working tree you're
  executing in, with at least one commit (current directory: &lt;PWD&gt;).
  If this is a new project, run 'git init' and make a first commit,
  then rerun.

sdd-repo gains --with-commit, which also refuses a repository whose HEAD
has no commit. review-package, task-start and task-done pass it because
they need HEAD as a BASE or a review range; sdd-workspace and task-brief
do not, so a brief can still be written right after git init.
task-start and task-done now read HEAD and BASE with git -C in the
repository sdd-repo names. Resolution is otherwise unchanged: the cwd's
repo, else the plan's, else exit 2. sdd-repo is now executable like its
siblings.

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sdd-repo's no-repository message told every caller to run 'git init'.
That is the right fix for a new project, but the other way to reach it
is standing in the wrong directory, such as the plugin's own skill
directory after reading "from this skill's directory" literally. There,
'git init' would turn the plugin cache into a repository and hide the
real mistake.

task-start and task-done were worse. They still read HEAD and BASE in
the bare cwd while the brief and ledger went through sdd-repo. From a
non-repo cwd with the plan in a repo that has commits, task-start wrote
the brief into the plan's repo, then printed git's fatal plus "HEAD has
no commit yet ... make an initial commit first" and exited 2. task-done
printed git's fatal. review-package in a repo with no commit said
"bad BASE: HEAD~1".

Every helper that can hit this (sdd-workspace, task-brief,
review-package, task-start, task-done) now stops with the same message
from sdd-repo, naming the current directory and offering init-and-commit
only as the new-project case:

  SDD scripts must run from inside the git working tree you're
  executing in, with at least one commit (current directory: &lt;PWD&gt;).
  If this is a new project, run 'git init' and make a first commit,
  then rerun.

sdd-repo gains --with-commit, which also refuses a repository whose HEAD
has no commit. review-package, task-start and task-done pass it because
they need HEAD as a BASE or a review range; sdd-workspace and task-brief
do not, so a brief can still be written right after git init.
task-start and task-done now read HEAD and BASE with git -C in the
repository sdd-repo names. Resolution is otherwise unchanged: the cwd's
repo, else the plan's, else exit 2. sdd-repo is now executable like its
siblings.

Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(sdd): pick the scripts' repository deliberately, add -C DIR, explain a missing repo</title>
<updated>2026-10-23T00:21:52+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@fsck.com</email>
</author>
<published>2026-10-22T22:24:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=614d80c29a4ad0c0fffb8c49ce5fc5b8afa0bf42'/>
<id>614d80c29a4ad0c0fffb8c49ce5fc5b8afa0bf42</id>
<content type='text'>
The SDD helpers found their repository with a bare
`git rev-parse --show-toplevel` in the caller's cwd, and review-package ran
every git command there too. Three reports trace back to that one line:

- #2429: outside any repository (the skill's own directory in a 7.0
  package has no .git), sdd-workspace fed `cd` an empty path. bash 5.2
  treats that as a no-op and wrote the workspace into the cwd after
  printing git's bare fatal; Git Bash failed with "cd: null directory".
  A controller working on worktree B from worktree A had no way to name B.
- #1799: the only way to aim review-package at a worktree was a
  `cd &lt;worktree&gt; ; review-package ...` compound, which harnesses cannot
  allowlist because the path and BASE change on every run.
- #2242: in a greenfield directory with no repository, task-brief and
  sdd-workspace printed git's fatal and then carried on in the cwd (or
  crashed, depending on bash), review-package said "bad BASE: HEAD~1", and
  task-start printed an empty BASE with exit 0.

A new sdd-repo helper is the single place that picks the repository:
the cwd's working tree (or -C DIR's), exactly as git does. Anywhere else
it stops with exit 2 and one shared message.
sdd-workspace and review-package both use it, so they cannot disagree.
The cwd still wins over the plan's location on purpose: writing-plans
leaves the plan uncommitted in the main checkout, so an executor working
in a linked worktree passes the main checkout's plan path, and its
workspace and commits belong to the worktree. Resolving from PLAN_FILE
first (draft #2439) breaks exactly that flow: review-package then diffs
the main checkout and fails with "empty commit range".

sdd-workspace, task-brief and review-package take an optional leading
`-C DIR` that runs them as if started in DIR, as git -C does, so a caller
can name another worktree in one allowlistable command. Each script
resolves its own directory before the cd, so the documented
`bash scripts/review-package` form from the skill directory keeps
working with -C. PR #1809's version cd's first and then fails to find
sdd-workspace (exit 127) in that form.

task-start now refuses (exit 2) to print a BASE when HEAD has no commit,
instead of printing "base: HEAD" or "base: " with exit 0.

Co-authored-by: citizen204 &lt;citizen204@users.noreply.github.com&gt;
Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The SDD helpers found their repository with a bare
`git rev-parse --show-toplevel` in the caller's cwd, and review-package ran
every git command there too. Three reports trace back to that one line:

- #2429: outside any repository (the skill's own directory in a 7.0
  package has no .git), sdd-workspace fed `cd` an empty path. bash 5.2
  treats that as a no-op and wrote the workspace into the cwd after
  printing git's bare fatal; Git Bash failed with "cd: null directory".
  A controller working on worktree B from worktree A had no way to name B.
- #1799: the only way to aim review-package at a worktree was a
  `cd &lt;worktree&gt; ; review-package ...` compound, which harnesses cannot
  allowlist because the path and BASE change on every run.
- #2242: in a greenfield directory with no repository, task-brief and
  sdd-workspace printed git's fatal and then carried on in the cwd (or
  crashed, depending on bash), review-package said "bad BASE: HEAD~1", and
  task-start printed an empty BASE with exit 0.

A new sdd-repo helper is the single place that picks the repository:
the cwd's working tree (or -C DIR's), exactly as git does. Anywhere else
it stops with exit 2 and one shared message.
sdd-workspace and review-package both use it, so they cannot disagree.
The cwd still wins over the plan's location on purpose: writing-plans
leaves the plan uncommitted in the main checkout, so an executor working
in a linked worktree passes the main checkout's plan path, and its
workspace and commits belong to the worktree. Resolving from PLAN_FILE
first (draft #2439) breaks exactly that flow: review-package then diffs
the main checkout and fails with "empty commit range".

sdd-workspace, task-brief and review-package take an optional leading
`-C DIR` that runs them as if started in DIR, as git -C does, so a caller
can name another worktree in one allowlistable command. Each script
resolves its own directory before the cd, so the documented
`bash scripts/review-package` form from the skill directory keeps
working with -C. PR #1809's version cd's first and then fails to find
sdd-workspace (exit 127) in that form.

task-start now refuses (exit 2) to print a BASE when HEAD has no commit,
instead of printing "base: HEAD" or "base: " with exit 0.

Co-authored-by: citizen204 &lt;citizen204@users.noreply.github.com&gt;
Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(sdd): print a Windows-readable workspace path (#2307)</title>
<updated>2026-10-22T23:26:01+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@fsck.com</email>
</author>
<published>2026-10-22T22:21:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=bb3a5aa594ffd34259ecabd7392fd627fa2109a7'/>
<id>bb3a5aa594ffd34259ecabd7392fd627fa2109a7</id>
<content type='text'>
On Windows, sdd-workspace printed the workspace in MSYS form
(/c/Users/... or /tmp/...). Every helper path derives from that line:
task-brief's "wrote", review-package's diff path, executing-plans'
task-start "brief:". PowerShell resolves /c/Users/x as C:\c\Users\x, so
Test-Path and Get-Content on any of them failed. That is the shell an
agent gets from Claude Code's PowerShell tool and from Copilot CLI on
Windows. Reproduced on Windows 11 from PowerShell and from Claude Code
2.1.308's PowerShell tool.

When cygpath is present (Git Bash, MSYS2, Cygwin), print the path
through `cygpath -m`, which gives C:/Users/.... PowerShell, cmd and
Claude Code's Read tool all accept that form, and so does bash, so the
sibling scripts that build file names on top of it keep working.
Elsewhere the output is unchanged.

Only the printed line changes. The plan-path markers keep pwd -P's
spelling, so workspaces created before this change, including absolute
markers for out-of-repo plans, still match their plans. PR #2369
converted root and the plan path too, which would rewrite those
absolute markers and orphan existing workspaces for out-of-repo plans.

Tests: physical_path in both suites now spells paths the way the
scripts print them, and test-sdd-workspace adds a check that PowerShell
can open the printed workspace and brief paths. That check runs on
Windows and is a no-op elsewhere. On Windows the suites failed 10 and 1
assertions before the fix, and both pass after.

Co-authored-by: hzxxxx &lt;hhuihihiux@users.noreply.github.com&gt;
Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On Windows, sdd-workspace printed the workspace in MSYS form
(/c/Users/... or /tmp/...). Every helper path derives from that line:
task-brief's "wrote", review-package's diff path, executing-plans'
task-start "brief:". PowerShell resolves /c/Users/x as C:\c\Users\x, so
Test-Path and Get-Content on any of them failed. That is the shell an
agent gets from Claude Code's PowerShell tool and from Copilot CLI on
Windows. Reproduced on Windows 11 from PowerShell and from Claude Code
2.1.308's PowerShell tool.

When cygpath is present (Git Bash, MSYS2, Cygwin), print the path
through `cygpath -m`, which gives C:/Users/.... PowerShell, cmd and
Claude Code's Read tool all accept that form, and so does bash, so the
sibling scripts that build file names on top of it keep working.
Elsewhere the output is unchanged.

Only the printed line changes. The plan-path markers keep pwd -P's
spelling, so workspaces created before this change, including absolute
markers for out-of-repo plans, still match their plans. PR #2369
converted root and the plan path too, which would rewrite those
absolute markers and orphan existing workspaces for out-of-repo plans.

Tests: physical_path in both suites now spells paths the way the
scripts print them, and test-sdd-workspace adds a check that PowerShell
can open the printed workspace and brief paths. That check runs on
Windows and is a no-op elsewhere. On Windows the suites failed 10 and 1
assertions before the fix, and both pass after.

Co-authored-by: hzxxxx &lt;hhuihihiux@users.noreply.github.com&gt;
Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
</pre>
</div>
</content>
</entry>
<entry>
<title>test(executing-plans): compare the brief path in the scripts' own spelling on Git Bash</title>
<updated>2026-09-27T02:30:38+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@primeradiant.com</email>
</author>
<published>2026-09-27T02:30:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=49b1db53d86d358a0a60446ccecba81c7595f7d0'/>
<id>49b1db53d86d358a0a60446ccecba81c7595f7d0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(executing-plans): task-done no longer aborts when a passing test prints nothing (#2388)</title>
<updated>2026-09-26T19:36:39+00:00</updated>
<author>
<name>ada-sen</name>
<email>ada.sen@primeradiant.com</email>
</author>
<published>2026-09-26T19:36:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=907ad21ac21d0159ac3625c67537634bcb928c24'/>
<id>907ad21ac21d0159ac3625c67537634bcb928c24</id>
<content type='text'>
Under `set -euo pipefail`, task-done extracted the ledger's test-result
field with:

    last=$(grep -v '^[[:space:]]*$' "$log" | tail -n 1)

When the test command passes but the log is empty or blank-only, `grep -v`
matches no lines and exits 1; pipefail propagates that through the
pipeline, and set -e aborts the assignment before the ledger line is
written. A passing task is then silently not recorded: exit 1, no stderr,
no ledger entry — indistinguishable from the failure path the guard exists
to produce.

Make the no-match case non-fatal, falling back to a literal placeholder for
the ledger field:

    last=$(grep -v '^[[:space:]]*$' "$log" | tail -n 1) || last="(no output)"

The failure guard above this line (recording nothing when the test command
itself exits non-zero) is untouched.

Fixes #2385.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Under `set -euo pipefail`, task-done extracted the ledger's test-result
field with:

    last=$(grep -v '^[[:space:]]*$' "$log" | tail -n 1)

When the test command passes but the log is empty or blank-only, `grep -v`
matches no lines and exits 1; pipefail propagates that through the
pipeline, and set -e aborts the assignment before the ledger line is
written. A passing task is then silently not recorded: exit 1, no stderr,
no ledger entry — indistinguishable from the failure path the guard exists
to produce.

Make the no-match case non-fatal, falling back to a literal placeholder for
the ledger field:

    last=$(grep -v '^[[:space:]]*$' "$log" | tail -n 1) || last="(no output)"

The failure guard above this line (recording nothing when the test command
itself exits non-zero) is untouched.

Fixes #2385.</pre>
</div>
</content>
</entry>
<entry>
<title>Rebuild executing-plans as a first-class inline execution mode</title>
<updated>2026-09-18T00:14:38+00:00</updated>
<author>
<name>Jesse Vincent</name>
<email>jesse@primeradiant.com</email>
</author>
<published>2026-09-17T22:51:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.1991861.xyz/superpowers.git/commit/?id=2b89c4c3f375ab479c3bc0644a76fea78a0f44bb'/>
<id>2b89c4c3f375ab479c3bc0644a76fea78a0f44bb</id>
<content type='text'>
A cheaper execution mode alongside subagent-driven development: the
session implements every task itself under the same workspace, ledger
and stopping rules, with one fresh whole-branch review on the most
capable model at the end. Helper scripts task-start/task-done keep the
ledger and test log honest; the final fix pass re-grades findings and
fixes Critical/Important under TDD. writing-plans' handoff, SDD's
when-to-use text and two README lines change to match.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A cheaper execution mode alongside subagent-driven development: the
session implements every task itself under the same workspace, ledger
and stopping rules, with one fresh whole-branch review on the most
capable model at the end. Helper scripts task-start/task-done keep the
ledger and test log honest; the final fix pass re-grades findings and
fixes Critical/Important under TDD. writing-plans' handoff, SDD's
when-to-use text and two README lines change to match.
</pre>
</div>
</content>
</entry>
</feed>
