summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorDrew Ritter <drew@primeradiant.com>2026-05-14 14:48:16 -0700
committerDrew Ritter <drew@primeradiant.com>2026-05-14 15:51:53 -0700
commit935de5d5ec5d5ce72638050bdc00c6ac8a253af9 (patch)
tree0a1c31ff6ab1f06faad1cc88dcbb4a65d2629b09 /tests
parentf5c43d6055de499a69f3c506f690b4448c275e0e (diff)
Simplify Codex hook entrypointcodex/research-codex-plugin-hooks
Diffstat (limited to 'tests')
-rwxr-xr-xtests/codex-plugin-sync/test-sync-to-codex-plugin.sh19
-rwxr-xr-xtests/hooks/test-session-start.sh44
2 files changed, 31 insertions, 32 deletions
diff --git a/tests/codex-plugin-sync/test-sync-to-codex-plugin.sh b/tests/codex-plugin-sync/test-sync-to-codex-plugin.sh
index 716570b..a94cdec 100755
--- a/tests/codex-plugin-sync/test-sync-to-codex-plugin.sh
+++ b/tests/codex-plugin-sync/test-sync-to-codex-plugin.sh
@@ -228,7 +228,7 @@ EOF
"hooks": [
{
"type": "command",
- "command": "\"${PLUGIN_ROOT}/hooks/run-hook.cmd\" session-start",
+ "command": "\"${PLUGIN_ROOT}/hooks/run-hook.cmd\" session-start-codex",
"async": false
}
]
@@ -242,12 +242,16 @@ EOF
#!/usr/bin/env sh
echo "session-start fixture"
EOF
+ cat > "$repo/hooks/session-start-codex" <<'EOF'
+#!/usr/bin/env sh
+echo "session-start-codex fixture"
+EOF
cat > "$repo/hooks/run-hook.cmd" <<'EOF'
@echo off
echo run-hook fixture
EOF
- chmod +x "$repo/hooks/session-start" "$repo/hooks/run-hook.cmd"
+ chmod +x "$repo/hooks/session-start" "$repo/hooks/session-start-codex" "$repo/hooks/run-hook.cmd"
cat > "$repo/skills/example/SKILL.md" <<'EOF'
# Example Skill
@@ -270,6 +274,7 @@ EOF
hooks/hooks-codex.json \
hooks/run-hook.cmd \
hooks/session-start \
+ hooks/session-start-codex \
package.json \
scripts/sync-to-codex-plugin.sh \
skills/example/SKILL.md
@@ -353,7 +358,7 @@ EOF
"hooks": [
{
"type": "command",
- "command": "\"${PLUGIN_ROOT}/hooks/run-hook.cmd\" session-start",
+ "command": "\"${PLUGIN_ROOT}/hooks/run-hook.cmd\" session-start-codex",
"async": false
}
]
@@ -367,12 +372,16 @@ EOF
#!/usr/bin/env sh
echo "session-start fixture"
EOF
+ cat > "$repo/plugins/superpowers/hooks/session-start-codex" <<'EOF'
+#!/usr/bin/env sh
+echo "session-start-codex fixture"
+EOF
cat > "$repo/plugins/superpowers/hooks/run-hook.cmd" <<'EOF'
@echo off
echo run-hook fixture
EOF
- chmod +x "$repo/plugins/superpowers/hooks/session-start" "$repo/plugins/superpowers/hooks/run-hook.cmd"
+ chmod +x "$repo/plugins/superpowers/hooks/session-start" "$repo/plugins/superpowers/hooks/session-start-codex" "$repo/plugins/superpowers/hooks/run-hook.cmd"
cat > "$repo/plugins/superpowers/skills/example/SKILL.md" <<'EOF'
# Example Skill
@@ -395,6 +404,7 @@ EOF
plugins/superpowers/hooks/hooks-codex.json \
plugins/superpowers/hooks/run-hook.cmd \
plugins/superpowers/hooks/session-start \
+ plugins/superpowers/hooks/session-start-codex \
plugins/superpowers/skills/example/agents/openai.yaml \
plugins/superpowers/skills/example/SKILL.md \
plugins/superpowers/.private-journal/keep.txt
@@ -612,6 +622,7 @@ main() {
assert_contains "$preview_section" "assets/app-icon.png" "Preview includes PNG asset"
assert_contains "$preview_section" "hooks/hooks-codex.json" "Preview includes Codex hook manifest"
assert_contains "$preview_section" "hooks/session-start" "Preview includes session-start hook"
+ assert_contains "$preview_section" "hooks/session-start-codex" "Preview includes Codex session-start hook"
assert_contains "$preview_section" "hooks/run-hook.cmd" "Preview includes hook command wrapper"
assert_contains "$preview_section" ".private-journal/keep.txt" "Preview includes tracked ignored file"
assert_not_contains "$preview_section" ".private-journal/leak.txt" "Preview excludes ignored untracked file"
diff --git a/tests/hooks/test-session-start.sh b/tests/hooks/test-session-start.sh
index 58644ae..989d72c 100755
--- a/tests/hooks/test-session-start.sh
+++ b/tests/hooks/test-session-start.sh
@@ -4,6 +4,7 @@ set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
HOOK_UNDER_TEST="$REPO_ROOT/hooks/session-start"
+CODEX_HOOK_UNDER_TEST="$REPO_ROOT/hooks/session-start-codex"
WRAPPER_UNDER_TEST="$REPO_ROOT/hooks/run-hook.cmd"
FAILURES=0
@@ -157,7 +158,7 @@ codex_home="$(make_home codex-plugin-hooks)"
codex_data="$TEST_ROOT/codex-plugin-hooks/data"
mkdir -p "$codex_data"
assert_command_output \
- "Codex plugin hooks emit nested SessionStart additionalContext" \
+ "Codex plugin hooks use dedicated script and emit nested SessionStart additionalContext" \
"nested" \
"" \
"" \
@@ -166,13 +167,13 @@ assert_command_output \
CLAUDE_PLUGIN_DATA="$codex_data" \
PLUGIN_ROOT="$REPO_ROOT" \
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
- bash "$HOOK_UNDER_TEST"
+ bash "$CODEX_HOOK_UNDER_TEST"
codex_wrapper_home="$(make_home codex-wrapper)"
codex_wrapper_data="$TEST_ROOT/codex-wrapper/data"
mkdir -p "$codex_wrapper_data"
assert_command_output \
- "Codex wrapper path emits nested SessionStart additionalContext" \
+ "Codex wrapper path dispatches to dedicated script" \
"nested" \
"" \
"" \
@@ -181,7 +182,7 @@ assert_command_output \
CLAUDE_PLUGIN_DATA="$codex_wrapper_data" \
PLUGIN_ROOT="$REPO_ROOT" \
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
- bash "$WRAPPER_UNDER_TEST" session-start
+ bash "$WRAPPER_UNDER_TEST" session-start-codex
cursor_home="$(make_home cursor)"
assert_command_output \
@@ -205,44 +206,31 @@ assert_command_output \
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
bash "$HOOK_UNDER_TEST"
-claude_legacy_home="$(make_home claude-legacy-warning)"
-mkdir -p "$claude_legacy_home/.config/superpowers/skills"
+legacy_home="$(make_home legacy-warning-removed)"
+mkdir -p "$legacy_home/.config/superpowers/skills"
assert_command_output \
- "Claude legacy warning points custom skills to ~/.claude/skills" \
+ "SessionStart omits obsolete legacy custom-skill warning" \
"nested" \
- "Superpowers now uses Claude Code's skills system. Custom skills in ~/.config/superpowers/skills will not be read. Move custom skills to ~/.claude/skills instead." \
"" \
- "$claude_legacy_home" \
+ "Superpowers now uses"$'\037'"~/.config/superpowers/skills"$'\037'"~/.claude/skills"$'\037'"legacy" \
+ "$legacy_home" \
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
bash "$HOOK_UNDER_TEST"
-claude_data_home="$(make_home claude-data-warning)"
-claude_data="$TEST_ROOT/claude-data-warning/data"
-mkdir -p "$claude_data_home/.config/superpowers/skills" "$claude_data"
-assert_command_output \
- "Claude with CLAUDE_PLUGIN_DATA still uses Claude legacy warning" \
- "nested" \
- "Superpowers now uses Claude Code's skills system. Custom skills in ~/.config/superpowers/skills will not be read. Move custom skills to ~/.claude/skills instead." \
- "" \
- "$claude_data_home" \
- CLAUDE_PLUGIN_DATA="$claude_data" \
- CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
- bash "$HOOK_UNDER_TEST"
-
-codex_legacy_home="$(make_home codex-legacy-warning)"
-codex_legacy_data="$TEST_ROOT/codex-legacy-warning/data"
+codex_legacy_home="$(make_home codex-legacy-warning-removed)"
+codex_legacy_data="$TEST_ROOT/codex-legacy-warning-removed/data"
mkdir -p "$codex_legacy_home/.config/superpowers/skills" "$codex_legacy_data"
assert_command_output \
- "Codex legacy warning uses harness-neutral custom-skill wording" \
+ "Codex SessionStart omits obsolete legacy custom-skill warning" \
"nested" \
- "WARNING: Superpowers now uses your coding agent's native skills system. Custom skills in ~/.config/superpowers/skills will not be read. Move custom skills to a skills location supported by your coding agent. To make this message go away, remove ~/.config/superpowers/skills" \
- "~/.claude/skills"$'\037'"Claude Code's skills system" \
+ "" \
+ "Superpowers now uses"$'\037'"~/.config/superpowers/skills"$'\037'"~/.claude/skills"$'\037'"legacy" \
"$codex_legacy_home" \
PLUGIN_DATA="$codex_legacy_data" \
CLAUDE_PLUGIN_DATA="$codex_legacy_data" \
PLUGIN_ROOT="$REPO_ROOT" \
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
- bash "$HOOK_UNDER_TEST"
+ bash "$CODEX_HOOK_UNDER_TEST"
if [[ "$FAILURES" -gt 0 ]]; then
echo "STATUS: FAILED ($FAILURES failure(s))"