summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJesse Vincent <jesse@fsck.com>2026-10-22 21:04:25 +0000
committerJesse Vincent <jesse@fsck.com>2026-10-22 21:04:25 +0000
commit8f4b3dbd2f5ef8163e4daed5ca43a4cf08eb5d8c (patch)
tree0f65e906e767b7b26f110b0630415f6c3e409f43 /tests
parent0f9581f6c1525b51dc1600b14d24f3db1f601446 (diff)
fix(opencode): tell the model skill ids are bare names (#2583)fix/2583-opencode-skill-names
Skills name each other with the Claude Code plugin namespace (`superpowers:brainstorming`), and the using-superpowers bootstrap that the OpenCode plugin injects says "Let's build X -> superpowers:brainstorming first". OpenCode registers superpowers skills under bare ids (`brainstorming`) on both flavors and its `skill` tool does an exact lookup, so a model that copies the namespaced form gets "Unable to load skill superpowers:brainstorming" (V2) or `Skill "superpowers:brainstorming" not found` (V1) and carries on without the skill. The OpenCode tool mapping said only "Invoke a skill -> OpenCode's native skill tool" and never stated the id convention. Reproduced on real hosts (OpenCode 2.1.2 and opencode-ai 1.19.4) with a scripted stub provider: the namespaced call fails, the bare id loads. Add the convention to the "Invoke a skill" line of both mappings, with each flavor's real skill parameter (V1 `name`, V2 `id`), and mirror it in docs/README.opencode.md. Skill prose keeps the prefix, which is correct on Claude Code; the translation belongs in the harness mapping, the same way the Hermes reference shows bare `skill_view("brainstorming")`. Claude-Session: https://claude.ai/code/session_01SHANcr4A71nzuU9et4Fnba
Diffstat (limited to 'tests')
-rw-r--r--tests/opencode/test-bootstrap-caching.mjs22
1 files changed, 22 insertions, 0 deletions
diff --git a/tests/opencode/test-bootstrap-caching.mjs b/tests/opencode/test-bootstrap-caching.mjs
index 386b7b1..39e4daa 100644
--- a/tests/opencode/test-bootstrap-caching.mjs
+++ b/tests/opencode/test-bootstrap-caching.mjs
@@ -76,6 +76,9 @@ const failures = scenario === 'present'
if (scenario === 'present') {
failures.push(...assertV2Bootstrap(result));
+ // #2583: both flavors register bare skill ids and look them up exactly.
+ failures.push(...assertTeachesBareSkillIds('V1', bootstrapText(firstOutput), 'name'));
+ failures.push(...assertTeachesBareSkillIds('V2', v2Result.text, 'id'));
}
failures.push(...mappingFailures);
@@ -202,6 +205,25 @@ function assertMappingConstants(mod) {
return failures;
}
+// #2583: skills reference each other as `superpowers:<name>` (the Claude Code
+// plugin namespace), but OpenCode V1 and V2 register bare ids (`brainstorming`)
+// and their `skill` tools do an exact lookup, so a namespaced call fails with
+// "Unable to load skill". When the injected bootstrap contains namespaced
+// references, its tool mapping must tell the model to drop the prefix, using
+// the flavor's `skill` parameter (V1 `name`, V2 `id`).
+function assertTeachesBareSkillIds(flavor, text, param) {
+ const failures = [];
+ const refs = [...new Set(text.match(/superpowers:[a-z0-9-]+/g) || [])];
+ if (refs.length === 0) return failures;
+ if (!text.includes('drop the `superpowers:` prefix')) {
+ failures.push(`expected ${flavor} bootstrap to tell the model to drop the superpowers: prefix (bootstrap references ${refs.join(', ')})`);
+ }
+ if (!text.includes(`\`superpowers:brainstorming\` → \`skill\` with \`${param}: "brainstorming"\``)) {
+ failures.push(`expected ${flavor} bootstrap to show superpowers:brainstorming loading as \`skill\` with \`${param}: "brainstorming"\``);
+ }
+ return failures;
+}
+
// Drive setup() with a mock V2 ctx and fire the captured "context" hook on a
// top-level (parentID-less) session. Returns the injected-part count and the
// injected bootstrap text ('' when nothing was injected).