blob: e4e3904af6ee7773813939dbc890cfb4448e60ef (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
#!/usr/bin/env bash
# Tests for executing-plans' bookkeeping helpers: scripts/task-start extracts
# the brief and records BASE in one call; scripts/task-done runs the task's
# test command, records the result in the ledger, and refuses to record a
# failing task.
set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
EP_SCRIPTS="$REPO_ROOT/skills/executing-plans/scripts"
FAILURES=0
TEST_ROOT=""
pass() { echo " [PASS] $1"; }
fail() {
echo " [FAIL] $1"
FAILURES=$((FAILURES + 1))
}
cleanup() {
if [[ -n "$TEST_ROOT" && -d "$TEST_ROOT" ]]; then
rm -rf "$TEST_ROOT"
fi
}
main() {
echo "=== Test: executing-plans scripts ==="
TEST_ROOT="$(mktemp -d)"
trap cleanup EXIT
git init -q -b main "$TEST_ROOT/repo"
local repo
repo="$(cd "$TEST_ROOT/repo" && git rev-parse --show-toplevel)"
# Same spelling as the scripts print (pwd), not rev-parse's C:/... on Git Bash.
repo="$(cd "$repo" && pwd)"
local git_id=(-c user.email=t@example.com -c user.name=t -c commit.gpgsign=false)
cat > "$repo/plan.md" <<'PLAN'
# Plan
## Task 1: First thing
Do the first thing.
## Task 2: Second thing
Do the second thing.
PLAN
( cd "$repo" && git add plan.md && git "${git_id[@]}" commit -qm fixture )
local base
base="$(cd "$repo" && git rev-parse HEAD)"
# --- task-start: argument validation ---
local rc=0
(cd "$repo" && "$EP_SCRIPTS/task-start" plan.md >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 2 ]]; then
pass "task-start without a task number errors with exit 2"
else
fail "task-start without a task number errors with exit 2 (got $rc)"
fi
# --- task-start: brief path + BASE in one call ---
local out
out="$(cd "$repo" && "$EP_SCRIPTS/task-start" plan.md 1)"
if [[ "$out" == *"brief: $repo/.superpowers/sdd/plan/task-1-brief.md"* ]]; then
pass "task-start prints the brief path under the plan's workspace"
else
fail "task-start prints the brief path under the plan's workspace"
echo " got: $out"
fi
if [[ "$out" == *"base: $base"* ]]; then
pass "task-start prints BASE as the current HEAD"
else
fail "task-start prints BASE as the current HEAD"
echo " got: $out"
fi
if [[ -s "$repo/.superpowers/sdd/plan/task-1-brief.md" ]]; then
pass "task-start writes the brief file"
else
fail "task-start writes the brief file"
fi
# --- task-done: records a passing task ---
( cd "$repo" && echo x > work.txt && git add work.txt && git "${git_id[@]}" commit -qm "task 1" )
local head
head="$(cd "$repo" && git rev-parse HEAD)"
out="$(cd "$repo" && "$EP_SCRIPTS/task-done" plan.md 1 "$base" -- sh -c 'echo "Ran 3 tests"; echo OK')"
rc=$?
local ledger="$repo/.superpowers/sdd/plan/progress.md"
local expected="Task 1: complete (commits ${base:0:7}..${head:0:7}, tests: sh -c 'echo \"Ran 3 tests\"; echo OK' → OK)"
if [[ -f "$ledger" ]] && grep -qF "$expected" "$ledger"; then
pass "task-done appends the completion line with commit range and test result"
else
fail "task-done appends the completion line with commit range and test result"
echo " expected: $expected"
echo " ledger:"; sed 's/^/ /' "$ledger" 2>/dev/null || echo " (missing)"
fi
if [[ "$out" == *"OK"* ]]; then
pass "task-done prints the tail of the test output"
else
fail "task-done prints the tail of the test output"
echo " got: $out"
fi
if [[ -s "$repo/.superpowers/sdd/plan/task-1-tests.log" ]]; then
pass "task-done keeps the full test output in the workspace"
else
fail "task-done keeps the full test output in the workspace"
fi
# --- task-done: refuses to record a failing task ---
rc=0
out="$(cd "$repo" && "$EP_SCRIPTS/task-done" plan.md 2 "$head" -- sh -c 'echo "FAILED (errors=1)"; exit 1' 2>&1)" || rc=$?
if [[ "$rc" -ne 0 ]]; then
pass "task-done exits non-zero when the test command fails"
else
fail "task-done exits non-zero when the test command fails"
fi
if ! grep -q "Task 2: complete" "$ledger"; then
pass "task-done does not record a failing task as complete"
else
fail "task-done does not record a failing task as complete"
fi
if [[ "$out" == *"FAILED"* ]]; then
pass "task-done shows the failing output"
else
fail "task-done shows the failing output"
echo " got: $out"
fi
# --- task-done: records a passing task whose test command prints nothing ---
# https://github.com/obra/superpowers/issues/2385 -- under `set -euo
# pipefail`, the ledger's `grep -v '^[[:space:]]*$' log | tail -n 1`
# exits 1 on an empty/blank log, which used to abort the whole script
# (silently, no ledger line) even though the test command itself passed.
( cd "$repo" && echo y > work2.txt && git add work2.txt && git "${git_id[@]}" commit -qm "task 2" )
local head2
head2="$(cd "$repo" && git rev-parse HEAD)"
rc=0
out="$(cd "$repo" && "$EP_SCRIPTS/task-done" plan.md 2 "$head" -- true 2>&1)" || rc=$?
if [[ "$rc" -eq 0 ]]; then
pass "task-done exits 0 when a passing test command prints nothing"
else
fail "task-done exits 0 when a passing test command prints nothing (got rc=$rc)"
echo " got: $out"
fi
local expected2="Task 2: complete (commits ${head:0:7}..${head2:0:7}, tests: true → (no output))"
if [[ -f "$ledger" ]] && grep -qF "$expected2" "$ledger"; then
pass "task-done records a passing task that printed no output"
else
fail "task-done records a passing task that printed no output"
echo " expected: $expected2"
echo " ledger:"; sed 's/^/ /' "$ledger" 2>/dev/null || echo " (missing)"
fi
echo
if [[ "$FAILURES" -eq 0 ]]; then
echo "PASS"
else
echo "FAIL ($FAILURES)"
exit 1
fi
}
main "$@"
|