summaryrefslogtreecommitdiff
path: root/plugins/code-modernization/commands
diff options
context:
space:
mode:
authorMorgan Westlee Lunt <morganl@anthropic.com>2026-06-10 00:28:19 +0000
committerMorgan Westlee Lunt <morganl@anthropic.com>2026-06-10 00:28:19 +0000
commit8e61adb4c7f574e4bb7b03a0f242065c95b36f58 (patch)
tree49ff21bb1f5d95064b4ab89129508801402ca8cd /plugins/code-modernization/commands
parent3b9df6160068f836214bfae942a2ca2530489c84 (diff)
code-modernization: simplify README; give uplift its own modernized/ rootcodemod-dynamic-workflows
Adversarial re-audit of the current (post-uplift) state found the plugin internally consistent (no blocker/high issues). Two follow-ups: README rewrite for clarity (209 -> 122 lines, ~halved): - Reorder so a newcomer goes what-it-is -> install -> quickstart -> command reference -> deeper notes, instead of hitting two dense design essays before the command list. - Lead with what it produces; add a 3-command teaser. - Collapse the 'Dynamic workflow orchestration' and 'Untrusted code & prompt injection' essays and the COCOMO note into short, plain sections at the bottom; drop the internal 'Bash isn't a tool-lock' hedging and per-defense enumeration (kept the load-bearing points: untrusted-code threat model, secrets quarantine, COCOMO-is-not-a-timeline). - Remove cross-section redundancy (build methods, read-only caveat, scaffolder write-scope, dir convention each stated once now); gloss strangler-fig/JOBOL inline. Path nit from the audit: uplift now writes to modernized/<system>-uplifted/ (mirroring reimagine's -reimagined/) so the three build paths occupy disjoint roots and status can't mis-detect an uplift copy as transform modules. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'plugins/code-modernization/commands')
-rw-r--r--plugins/code-modernization/commands/modernize-status.md2
-rw-r--r--plugins/code-modernization/commands/modernize-uplift.md10
2 files changed, 6 insertions, 6 deletions
diff --git a/plugins/code-modernization/commands/modernize-status.md b/plugins/code-modernization/commands/modernize-status.md
index 0a7b3c99..c4de7860 100644
--- a/plugins/code-modernization/commands/modernize-status.md
+++ b/plugins/code-modernization/commands/modernize-status.md
@@ -19,7 +19,7 @@ workflow stage, with the artifact's presence and modification time:
| extract-rules | `BUSINESS_RULES.md`, `DATA_OBJECTS.md` |
| brief | `MODERNIZATION_BRIEF.md` (note whether the approval block is signed) |
| harden | `SECURITY_FINDINGS.md`, `security_remediation.patch` |
-| uplift | `DELTA_CATALOG.md`; `modernized/$1/UPLIFT_NOTES.md` (note per-project: builds on target? baseline reproduced?) |
+| uplift | `DELTA_CATALOG.md`; `modernized/$1-uplifted/UPLIFT_NOTES.md` (note per-project: builds on target? baseline reproduced?) |
| transform | each `modernized/$1/<module>/` dir — note test presence and whether `TRANSFORMATION_NOTES.md` exists |
| reimagine | `modernized/$1-reimagined/` — note per-service acceptance tests and the `CLAUDE.md` handoff (reimagine's completion markers; it does NOT write `TRANSFORMATION_NOTES.md`) |
diff --git a/plugins/code-modernization/commands/modernize-uplift.md b/plugins/code-modernization/commands/modernize-uplift.md
index 7aa95fca..3a107aed 100644
--- a/plugins/code-modernization/commands/modernize-uplift.md
+++ b/plugins/code-modernization/commands/modernize-uplift.md
@@ -74,9 +74,9 @@ Run `/modernize-preflight $1 $3` for the full readiness report.
place* — it bumps target frameworks and fixes APIs while keeping the `.sln`,
the relative `<ProjectReference>`/module paths, and a reviewable `git diff`.
That is fundamentally different from `transform`/`reimagine`, which write a
-new tree. So: **copy the whole system once** — `cp -r legacy/$1 modernized/$1`
+new tree. So: **copy the whole system once** — `cp -r legacy/$1 modernized/$1-uplifted`
(the entire solution, not project-by-project) — and do all editing in place
-under `modernized/$1/`, git-tracked. `legacy/$1` stays the untouched baseline
+under `modernized/$1-uplifted/`, git-tracked. `legacy/$1` stays the untouched baseline
oracle. Copying the *whole* solution (not incrementally) is what keeps
relative project references intact and makes the final artifact a real
`git diff` between the seeded copy and the end state — which is exactly what a
@@ -185,11 +185,11 @@ gap-fill tests to expected/recorded outputs and label the proof target-only.
## Step 5 — Migrate, leaf-first, minimal-diff
-All editing happens **in place inside the working copy `modernized/$1/`** from
+All editing happens **in place inside the working copy `modernized/$1-uplifted/`** from
Step 1 (so relative project references resolve and the result is a clean
`git diff` against the seeded copy). `legacy/$1` is never touched. Apply-mode
tools (`upgrade-assistant`, `ng update`) mutate the tree in place — that is
-fine *here* because they run against the `modernized/$1/` copy, not `legacy/`.
+fine *here* because they run against the `modernized/$1-uplifted/` copy, not `legacy/`.
For each project in dependency order (respecting the Step 1 overrides):
1. **Run the ecosystem codemod** for the Mechanical deltas (`upgrade-assistant`
@@ -216,7 +216,7 @@ Run the **same suite** on both targets (or target-only per Step 0.3):
## Step 7 — UPLIFT_NOTES
-Write `modernized/$1/UPLIFT_NOTES.md`:
+Write `modernized/$1-uplifted/UPLIFT_NOTES.md`:
- Delta → fix mapping (which catalog delta each diff addresses; which tool vs
hand-applied)
- Dual-run diff table (or "target-only — source runtime unavailable here")