diff options
Diffstat (limited to 'skills/subagent-driven-development/references')
| -rw-r--r-- | skills/subagent-driven-development/references/final-review.md | 6 | ||||
| -rw-r--r-- | skills/subagent-driven-development/references/fix-loop.md | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/skills/subagent-driven-development/references/final-review.md b/skills/subagent-driven-development/references/final-review.md index 851a5c5..cf03546 100644 --- a/skills/subagent-driven-development/references/final-review.md +++ b/skills/subagent-driven-development/references/final-review.md @@ -4,7 +4,8 @@ Part of superpowers:subagent-driven-development. Every task in the plan is complete. The final whole-branch review gets a package too: run -`bash scripts/review-package PLAN_FILE MERGE_BASE HEAD` (MERGE_BASE = the commit the +`bash scripts/review-package PLAN_FILE MERGE_BASE HEAD` by its absolute path, +from the working tree you're executing in (MERGE_BASE = the commit the branch started from, e.g. `git merge-base main HEAD`) and include the printed path in the final review dispatch, so the final reviewer reads one file instead of re-deriving the branch diff with git commands. Dispatch @@ -19,7 +20,8 @@ with the complete findings list — not one fixer per finding. Per-finding fixers each rebuild context and re-run suites; a real session's final-review fix wave cost more than all its tasks combined. Then run exactly one scoped re-review of the fix wave -(`bash scripts/review-package PLAN_FILE FIX_BASE HEAD` over the fix range, +(`bash scripts/review-package PLAN_FILE FIX_BASE HEAD` by its absolute path, +from the working tree you're executing in, over the fix range, [re-review-prompt.md](../re-review-prompt.md)). Adjudicate any residual findings as in the fix loop's breaker (references/fix-loop.md): park with rulings, or rule on the load-bearing diff --git a/skills/subagent-driven-development/references/fix-loop.md b/skills/subagent-driven-development/references/fix-loop.md index 0b476e9..34e4a48 100644 --- a/skills/subagent-driven-development/references/fix-loop.md +++ b/skills/subagent-driven-development/references/fix-loop.md @@ -42,7 +42,7 @@ covering test files in the fix message — a one-line fix does not need the whole suite. **The re-review is scoped.** Run `bash scripts/review-package PLAN_FILE FIX_BASE HEAD` -where FIX_BASE is the head the previous review saw, and dispatch +by its absolute path, from the working tree you're executing in, where FIX_BASE is the head the previous review saw, and dispatch [re-review-prompt.md](../re-review-prompt.md) with the findings list, the brief, the report file, and the printed diff path. The re-reviewer verdicts each finding ADDRESSED or NOT ADDRESSED and flags new breakage in the fix |
