diff options
Diffstat (limited to 'tests/claude-code')
| -rwxr-xr-x | tests/claude-code/run-skill-tests.sh | 1 | ||||
| -rwxr-xr-x | tests/claude-code/test-executing-plans-scripts.sh | 139 | ||||
| -rwxr-xr-x | tests/claude-code/test-sdd-workspace.sh | 161 |
3 files changed, 301 insertions, 0 deletions
diff --git a/tests/claude-code/run-skill-tests.sh b/tests/claude-code/run-skill-tests.sh index 83217cd..97bce6d 100755 --- a/tests/claude-code/run-skill-tests.sh +++ b/tests/claude-code/run-skill-tests.sh @@ -76,6 +76,7 @@ done tests=( "test-worktree-path-policy.sh" "test-sdd-workspace.sh" + "test-executing-plans-scripts.sh" "test-subagent-driven-development.sh" ) diff --git a/tests/claude-code/test-executing-plans-scripts.sh b/tests/claude-code/test-executing-plans-scripts.sh new file mode 100755 index 0000000..994733b --- /dev/null +++ b/tests/claude-code/test-executing-plans-scripts.sh @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +# Tests for executing-plans' bookkeeping helpers: scripts/task-start extracts +# the brief and records BASE in one call; scripts/task-done runs the task's +# test command, records the result in the ledger, and refuses to record a +# failing task. +set -euo pipefail + +SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)" +EP_SCRIPTS="$REPO_ROOT/skills/executing-plans/scripts" + +FAILURES=0 +TEST_ROOT="" + +pass() { echo " [PASS] $1"; } +fail() { + echo " [FAIL] $1" + FAILURES=$((FAILURES + 1)) +} + +cleanup() { + if [[ -n "$TEST_ROOT" && -d "$TEST_ROOT" ]]; then + rm -rf "$TEST_ROOT" + fi +} + +main() { + echo "=== Test: executing-plans scripts ===" + + TEST_ROOT="$(mktemp -d)" + trap cleanup EXIT + + git init -q -b main "$TEST_ROOT/repo" + local repo + repo="$(cd "$TEST_ROOT/repo" && git rev-parse --show-toplevel)" + local git_id=(-c user.email=t@example.com -c user.name=t -c commit.gpgsign=false) + + cat > "$repo/plan.md" <<'PLAN' +# Plan + +## Task 1: First thing + +Do the first thing. + +## Task 2: Second thing + +Do the second thing. +PLAN + ( cd "$repo" && git add plan.md && git "${git_id[@]}" commit -qm fixture ) + local base + base="$(cd "$repo" && git rev-parse HEAD)" + + # --- task-start: argument validation --- + local rc=0 + (cd "$repo" && "$EP_SCRIPTS/task-start" plan.md >/dev/null 2>&1) || rc=$? + if [[ "$rc" -eq 2 ]]; then + pass "task-start without a task number errors with exit 2" + else + fail "task-start without a task number errors with exit 2 (got $rc)" + fi + + # --- task-start: brief path + BASE in one call --- + local out + out="$(cd "$repo" && "$EP_SCRIPTS/task-start" plan.md 1)" + if [[ "$out" == *"brief: $repo/.superpowers/sdd/plan/task-1-brief.md"* ]]; then + pass "task-start prints the brief path under the plan's workspace" + else + fail "task-start prints the brief path under the plan's workspace" + echo " got: $out" + fi + if [[ "$out" == *"base: $base"* ]]; then + pass "task-start prints BASE as the current HEAD" + else + fail "task-start prints BASE as the current HEAD" + echo " got: $out" + fi + if [[ -s "$repo/.superpowers/sdd/plan/task-1-brief.md" ]]; then + pass "task-start writes the brief file" + else + fail "task-start writes the brief file" + fi + + # --- task-done: records a passing task --- + ( cd "$repo" && echo x > work.txt && git add work.txt && git "${git_id[@]}" commit -qm "task 1" ) + local head + head="$(cd "$repo" && git rev-parse HEAD)" + out="$(cd "$repo" && "$EP_SCRIPTS/task-done" plan.md 1 "$base" -- sh -c 'echo "Ran 3 tests"; echo OK')" + rc=$? + local ledger="$repo/.superpowers/sdd/plan/progress.md" + local expected="Task 1: complete (commits ${base:0:7}..${head:0:7}, tests: sh -c 'echo \"Ran 3 tests\"; echo OK' → OK)" + if [[ -f "$ledger" ]] && grep -qF "$expected" "$ledger"; then + pass "task-done appends the completion line with commit range and test result" + else + fail "task-done appends the completion line with commit range and test result" + echo " expected: $expected" + echo " ledger:"; sed 's/^/ /' "$ledger" 2>/dev/null || echo " (missing)" + fi + if [[ "$out" == *"OK"* ]]; then + pass "task-done prints the tail of the test output" + else + fail "task-done prints the tail of the test output" + echo " got: $out" + fi + if [[ -s "$repo/.superpowers/sdd/plan/task-1-tests.log" ]]; then + pass "task-done keeps the full test output in the workspace" + else + fail "task-done keeps the full test output in the workspace" + fi + + # --- task-done: refuses to record a failing task --- + rc=0 + out="$(cd "$repo" && "$EP_SCRIPTS/task-done" plan.md 2 "$head" -- sh -c 'echo "FAILED (errors=1)"; exit 1' 2>&1)" || rc=$? + if [[ "$rc" -ne 0 ]]; then + pass "task-done exits non-zero when the test command fails" + else + fail "task-done exits non-zero when the test command fails" + fi + if ! grep -q "Task 2: complete" "$ledger"; then + pass "task-done does not record a failing task as complete" + else + fail "task-done does not record a failing task as complete" + fi + if [[ "$out" == *"FAILED"* ]]; then + pass "task-done shows the failing output" + else + fail "task-done shows the failing output" + echo " got: $out" + fi + + echo + if [[ "$FAILURES" -eq 0 ]]; then + echo "PASS" + else + echo "FAIL ($FAILURES)" + exit 1 + fi +} + +main "$@" diff --git a/tests/claude-code/test-sdd-workspace.sh b/tests/claude-code/test-sdd-workspace.sh index 8417230..2e8c227 100755 --- a/tests/claude-code/test-sdd-workspace.sh +++ b/tests/claude-code/test-sdd-workspace.sh @@ -165,6 +165,30 @@ PLAN echo " got: $rp_explicit" fi + # --- range guards: BASE must be an ancestor of HEAD, range must be non-empty --- + local divergent + divergent="$(cd "$repo" && git "${git_id[@]}" commit-tree 'HEAD~1^{tree}' -p 'HEAD~1' -m divergent)" + rc=0 + local guard_err + guard_err="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md "$divergent" HEAD 2>&1 >/dev/null)" || rc=$? + if [[ "$rc" -eq 3 && "$guard_err" == *"not a descendant"* ]]; then + pass "review-package rejects a BASE that is not an ancestor of HEAD with exit 3" + else + fail "review-package rejects a BASE that is not an ancestor of HEAD with exit 3" + echo " exit: $rc" + echo " stderr: $guard_err" + fi + + rc=0 + guard_err="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md HEAD HEAD 2>&1 >/dev/null)" || rc=$? + if [[ "$rc" -eq 3 && "$guard_err" == *"empty commit range"* ]]; then + pass "review-package rejects an empty BASE..HEAD range with exit 3" + else + fail "review-package rejects an empty BASE..HEAD range with exit 3" + echo " exit: $rc" + echo " stderr: $guard_err" + fi + # --- Worktree isolation: a linked worktree resolves its own workspace --- local wt="$TEST_ROOT/wt" ( cd "$repo" && git worktree add -q "$wt" -b wt-feature ) @@ -189,6 +213,143 @@ PLAN echo " status: $wt_status" fi + # --- helpers survive a mode-stripping extractor dropping exec bits (#2040) --- + local stripped="$TEST_ROOT/stripped-scripts" + mkdir -p "$stripped" + cp "$SDD_SCRIPTS/sdd-workspace" "$SDD_SCRIPTS/task-brief" "$SDD_SCRIPTS/review-package" "$stripped/" + chmod -x "$stripped"/* + local noexec_out noexec_rc=0 + noexec_out="$(cd "$repo" && bash "$stripped/task-brief" plan-b.md 1 2>&1)" || noexec_rc=$? + if [[ "$noexec_rc" -eq 0 && -f "$repo/.superpowers/sdd/plan-b/task-1-brief.md" ]]; then + pass "task-brief works with no exec bit on sdd-workspace" + else + fail "task-brief works with no exec bit on sdd-workspace" + echo " rc: $noexec_rc" + echo " output: $noexec_out" + fi + + # --- Ownership markers: two plans with the same basename (#2045) --- + mkdir -p "$repo/docs/alpha" "$repo/docs/beta" + cat > "$repo/docs/alpha/plan.md" <<'PLAN' +# Alpha Plan + +## Task 1: Alpha work + +Alpha-only requirement text. +PLAN + cat > "$repo/docs/beta/plan.md" <<'PLAN' +# Beta Plan + +## Task 1: Beta work + +Beta-only requirement text. +PLAN + + local dir_alpha dir_beta + dir_alpha="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/alpha/plan.md)" + dir_beta="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/beta/plan.md)" + if [[ "$dir_alpha" != "$dir_beta" ]]; then + pass "same-basename plans resolve to distinct workspaces" + else + fail "same-basename plans resolve to distinct workspaces" + echo " alpha: $dir_alpha" + echo " beta: $dir_beta" + fi + + ( cd "$repo" && "$SDD_SCRIPTS/task-brief" docs/alpha/plan.md 1 >/dev/null ) + ( cd "$repo" && "$SDD_SCRIPTS/task-brief" docs/beta/plan.md 1 >/dev/null ) + if grep -q "Alpha-only requirement text." "$dir_alpha/task-1-brief.md" 2>/dev/null \ + && grep -q "Beta-only requirement text." "$dir_beta/task-1-brief.md" 2>/dev/null; then + pass "same-basename plans keep both task briefs intact" + else + fail "same-basename plans keep both task briefs intact" + echo " alpha brief: $(cat "$dir_alpha/task-1-brief.md" 2>/dev/null)" + echo " beta brief: $(cat "$dir_beta/task-1-brief.md" 2>/dev/null)" + fi + + # --- Legacy adoption: pre-existing workspace without a marker --- + printf '# Foo\n\n## Task 1: Foo\n\nFoo.\n' > "$repo/foo.md" + mkdir -p "$repo/.superpowers/sdd/foo" + printf 'ledger\n' > "$repo/.superpowers/sdd/foo/progress.md" + local dir_foo + dir_foo="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" foo.md)" + if [[ "$dir_foo" == "$repo/.superpowers/sdd/foo" \ + && -f "$dir_foo/progress.md" \ + && "$(cat "$dir_foo/plan-path" 2>/dev/null)" == "foo.md" ]]; then + pass "legacy markerless workspace is adopted in place and marked" + else + fail "legacy markerless workspace is adopted in place and marked" + echo " dir: $dir_foo" + echo " marker: $(cat "$dir_foo/plan-path" 2>/dev/null)" + fi + + # --- Ownership conflict: marker names a different plan --- + printf '# Bar\n\n## Task 1: Bar\n\nBar.\n' > "$repo/bar.md" + mkdir -p "$repo/.superpowers/sdd/bar" + printf 'somewhere-else/bar.md\n' > "$repo/.superpowers/sdd/bar/plan-path" + printf 'other ledger\n' > "$repo/.superpowers/sdd/bar/progress.md" + local dir_bar + dir_bar="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" bar.md)" + if [[ "$dir_bar" == "$repo/.superpowers/sdd/bar-repo" \ + && "$(cat "$dir_bar/plan-path" 2>/dev/null)" == "bar.md" ]]; then + pass "owned workspace disambiguates with parent-dir suffix" + else + fail "owned workspace disambiguates with parent-dir suffix" + echo " got: $dir_bar" + fi + if [[ "$(cat "$repo/.superpowers/sdd/bar/plan-path")" == "somewhere-else/bar.md" \ + && "$(cat "$repo/.superpowers/sdd/bar/progress.md")" == "other ledger" ]]; then + pass "conflicting plan leaves the original workspace untouched" + else + fail "conflicting plan leaves the original workspace untouched" + fi + + # --- Counter fallback: parent-suffixed workspace is owned too --- + printf '# Baz\n\n## Task 1: Baz\n\nBaz.\n' > "$repo/baz.md" + mkdir -p "$repo/.superpowers/sdd/baz" "$repo/.superpowers/sdd/baz-repo" + printf 'one/baz.md\n' > "$repo/.superpowers/sdd/baz/plan-path" + printf 'two/baz.md\n' > "$repo/.superpowers/sdd/baz-repo/plan-path" + local dir_baz + dir_baz="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" baz.md)" + if [[ "$dir_baz" == "$repo/.superpowers/sdd/baz-repo-2" \ + && "$(cat "$dir_baz/plan-path" 2>/dev/null)" == "baz.md" ]]; then + pass "double conflict falls back to a counter suffix" + else + fail "double conflict falls back to a counter suffix" + echo " got: $dir_baz" + fi + + # --- Same plan spelled differently resolves to one workspace --- + local dir_rel dir_abs dir_dotdot + dir_rel="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/alpha/plan.md)" + dir_abs="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" "$repo/docs/alpha/plan.md")" + dir_dotdot="$(cd "$repo/docs/beta" && "$SDD_SCRIPTS/sdd-workspace" ../alpha/plan.md)" + if [[ "$dir_rel" == "$dir_abs" && "$dir_rel" == "$dir_dotdot" \ + && "$(cat "$dir_rel/plan-path" 2>/dev/null)" == "docs/alpha/plan.md" ]]; then + pass "relative, absolute, and ../ spellings share one workspace and marker" + else + fail "relative, absolute, and ../ spellings share one workspace and marker" + echo " rel: $dir_rel" + echo " abs: $dir_abs" + echo " dotdot: $dir_dotdot" + echo " marker: $(cat "$dir_rel/plan-path" 2>/dev/null)" + fi + + # --- Out-of-repo plans keep working, marker holds the absolute path --- + mkdir -p "$TEST_ROOT/outside" + printf '# Remote\n\n## Task 1: Remote\n\nRemote.\n' > "$TEST_ROOT/outside/remote-plan.md" + local outside_abs dir_out + outside_abs="$(cd "$TEST_ROOT/outside" && pwd -P)/remote-plan.md" + dir_out="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" "$TEST_ROOT/outside/remote-plan.md")" + if [[ "$dir_out" == "$repo/.superpowers/sdd/remote-plan" \ + && "$(cat "$dir_out/plan-path" 2>/dev/null)" == "$outside_abs" ]]; then + pass "out-of-repo plan gets a basename slug and an absolute-path marker" + else + fail "out-of-repo plan gets a basename slug and an absolute-path marker" + echo " dir: $dir_out" + echo " marker: $(cat "$dir_out/plan-path" 2>/dev/null)" + fi + echo "" if [[ "$FAILURES" -ne 0 ]]; then echo "FAILED: $FAILURES assertion(s)." |
