1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
|
#!/usr/bin/env bash
# Tests for the SDD workspace: scripts/sdd-workspace resolves a self-ignoring,
# PER-PLAN working-tree directory for SDD artifacts, and the SDD scripts write
# into their plan's directory.
set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
SDD_SCRIPTS="$REPO_ROOT/skills/subagent-driven-development/scripts"
FAILURES=0
TEST_ROOT=""
pass() { echo " [PASS] $1"; }
fail() {
echo " [FAIL] $1"
FAILURES=$((FAILURES + 1))
}
# Push a path through the same normalization that sdd-workspace's own
# printed output goes through, so both sides of a string comparison are
# guaranteed to be spelled identically. On Windows (Git Bash/MSYS, Cygwin)
# that is the drive-letter form `cygpath -m` prints (C:/Users/...), not the
# MSYS form `pwd` prints (/c/Users/...); on Linux/macOS it is plain `pwd`
# (modulo the resolved-symlink /var -> /private/var case handled by the
# mktemp comment below).
physical_path() {
(cd "$1" && if command -v cygpath >/dev/null 2>&1; then cygpath -m "$PWD"; else pwd; fi)
}
# On Windows, check that PowerShell (the shell an agent's PowerShell tool
# runs) can open a path the helpers printed. Elsewhere there is nothing to
# check: the printed path is the shell's own.
native_readable() {
command -v cygpath >/dev/null 2>&1 && command -v powershell.exe >/dev/null 2>&1 || return 0
[[ "$(powershell.exe -NoProfile -Command "Test-Path -LiteralPath '$1'" | tr -d '\r')" == "True" ]]
}
cleanup() {
if [[ -n "$TEST_ROOT" && -d "$TEST_ROOT" ]]; then
rm -rf "$TEST_ROOT"
fi
}
main() {
echo "=== Test: sdd-workspace ==="
TEST_ROOT="$(mktemp -d)"
trap cleanup EXIT
# Resolve repo to its physical path so string comparisons match the
# helper's output (git rev-parse --show-toplevel resolves symlinks; on
# macOS mktemp lives under /var -> /private/var).
git init -q -b main "$TEST_ROOT/repo"
local repo
repo="$(cd "$TEST_ROOT/repo" && git rev-parse --show-toplevel)"
repo="$(physical_path "$repo")"
cat > "$repo/plan-a.md" <<'PLAN'
# Plan A
## Task 1: First thing
Do the first thing.
PLAN
cat > "$repo/plan-b.md" <<'PLAN'
# Plan B
## Task 1: Other thing
Do the other thing.
PLAN
# --- argument validation ---
local rc=0
(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 2 ]]; then
pass "sdd-workspace without a plan errors with exit 2"
else
fail "sdd-workspace without a plan errors with exit 2"
echo " exit: $rc"
fi
rc=0
(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" no-such-plan.md >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 2 ]]; then
pass "sdd-workspace with a missing plan file errors with exit 2"
else
fail "sdd-workspace with a missing plan file errors with exit 2"
echo " exit: $rc"
fi
# --- per-plan resolution ---
local dir_a dir_b
dir_a="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" plan-a.md)"
dir_b="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" plan-b.md)"
if [[ "$dir_a" == "$repo/.superpowers/sdd/plan-a" ]]; then
pass "prints <repo-root>/.superpowers/sdd/<plan-basename>"
else
fail "prints <repo-root>/.superpowers/sdd/<plan-basename>"
echo " got: $dir_a"
fi
if native_readable "$dir_a"; then
pass "the printed workspace path opens from PowerShell on Windows"
else
fail "the printed workspace path opens from PowerShell on Windows"
echo " got: $dir_a"
fi
if [[ "$dir_a" != "$dir_b" && -d "$dir_a" && -d "$dir_b" ]]; then
pass "two plans resolve to two distinct directories"
else
fail "two plans resolve to two distinct directories"
echo " a: $dir_a"
echo " b: $dir_b"
fi
if [[ -f "$repo/.superpowers/sdd/.gitignore" && "$(cat "$repo/.superpowers/sdd/.gitignore")" == "*" ]]; then
pass "self-ignoring .gitignore created at .superpowers/sdd/ with '*'"
else
fail "self-ignoring .gitignore created at .superpowers/sdd/ with '*'"
fi
printf 'x\n' > "$dir_a/artifact.md"
local status
status="$(cd "$repo" && git status --porcelain)"
# plan-a.md/plan-b.md are intentionally untracked fixture files; only the
# workspace must be invisible.
if [[ "$status" != *".superpowers"* ]]; then
pass "workspace invisible to git status"
else
fail "workspace invisible to git status"
echo " status: $status"
fi
( cd "$repo" && git add -A )
local staged
staged="$(cd "$repo" && git diff --cached --name-only)"
if [[ "$staged" != *".superpowers"* ]]; then
pass "git add -A does not stage the workspace"
else
fail "git add -A does not stage the workspace"
echo " staged: $staged"
fi
# --- task-brief lands in its plan's directory ---
local brief_out brief_path
brief_out="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-a.md 1)"
brief_path="$(printf '%s\n' "$brief_out" | sed -n 's/^wrote \(.*\): [0-9][0-9]* lines$/\1/p')"
if [[ "$brief_path" == "$repo/.superpowers/sdd/plan-a/task-1-brief.md" ]]; then
pass "task-brief writes its brief under the plan's workspace"
else
fail "task-brief writes its brief under the plan's workspace"
echo " got: $brief_path"
fi
if native_readable "$brief_path"; then
pass "the printed brief path opens from PowerShell on Windows"
else
fail "the printed brief path opens from PowerShell on Windows"
echo " got: $brief_path"
fi
# --- Task IDs: alphanumeric (#2459), matched whole, never as a prefix ---
cat > "$repo/plan-ids.md" <<'PLAN'
# Lanes Plan
## Task Overview
Shared context; not a task.
### Task A1: First lane
BODY-A1
#### Task notes
Still part of A1.
### Task A10: Same lane, later
BODY-A10
### Task 6: Numbered
BODY-6
### Task 6b: Sub-task
BODY-6B
### Task 2.1: Dotted
BODY-2.1
### Task 201: Decoy
BODY-201
PLAN
local id want got id_out="$TEST_ROOT/id-brief.md"
for id in A1 A10 6 6b 2.1 201; do
want="BODY-$(printf '%s' "$id" | tr '[:lower:]' '[:upper:]')"
rc=0
(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-ids.md "$id" "$id_out" >/dev/null 2>&1) || rc=$?
got="$(grep '^BODY-' "$id_out" 2>/dev/null | tr '\n' ' ')" || true
if [[ "$rc" -eq 0 && "$got" == "$want " ]]; then
pass "task-brief extracts Task $id and nothing else"
else
fail "task-brief extracts Task $id and nothing else"
echo " exit: $rc, bodies: $got"
fi
: > "$id_out"
done
(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-ids.md A1 "$id_out" >/dev/null 2>&1) || true
if grep -q 'Still part of A1.' "$id_out"; then
pass "a Task heading with no digit in its ID is not a task boundary"
else
fail "a Task heading with no digit in its ID is not a task boundary"
echo " brief: $(cat "$id_out" 2>/dev/null)"
fi
# A deeper heading whose ID extends the task's (7 -> 7a) is a sub-task and
# stays in the parent's brief; a deeper heading for another task (a plan
# that drifts from ## Task 9 to ### Task 10) is still a boundary.
cat > "$repo/plan-nested.md" <<'PLAN'
### Task 7: Parent
BODY-7
#### Task 7a: First part
BODY-7A
#### Task 7b: Second part
BODY-7B
### Task 8: Next
BODY-8
## Task 9: Shallower heading
BODY-9
### Task 10: Deeper, but not a sub-task
BODY-10
PLAN
for id in 7 7a 7b 8 9 10; do
case "$id" in
7) want="BODY-7 BODY-7A BODY-7B " ;;
*) want="BODY-$(printf '%s' "$id" | tr '[:lower:]' '[:upper:]') " ;;
esac
rc=0
(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-nested.md "$id" "$id_out" >/dev/null 2>&1) || rc=$?
got="$(grep '^BODY-' "$id_out" 2>/dev/null | tr '\n' ' ')" || true
if [[ "$rc" -eq 0 && "$got" == "$want" ]]; then
pass "nested plan: Task $id brief holds exactly its own section"
else
fail "nested plan: Task $id brief holds exactly its own section"
echo " exit: $rc, bodies: $got (want: $want)"
fi
done
for id in 2 '2|6' '6(' Overview; do
rc=0
(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-ids.md "$id" "$id_out" >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 3 ]]; then
pass "task-brief '$id' matches no task (exit 3)"
else
fail "task-brief '$id' matches no task (exit 3)"
echo " exit: $rc, brief: $(cat "$id_out" 2>/dev/null)"
fi
done
# --- Translated task headings: say so instead of "not found" (#2496) ---
cat > "$repo/plan-es.md" <<'PLAN'
# Plan: demo
## Tarea 1: Banner
**Archivos:**
## Tarea 2: Segunda
PLAN
local es_err
rc=0
es_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-es.md 1 "$id_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$es_err" == *'English word "Task"'* \
&& "$es_err" == *"## Tarea 1: Banner"* && "$es_err" == *"## Tarea 2: Segunda"* ]]; then
pass "task-brief on a plan with no Task headings names the headings it saw"
else
fail "task-brief on a plan with no Task headings names the headings it saw"
echo " exit: $rc"
echo " stderr: $es_err"
fi
# A plan that has Task headings, just not this one, gets the plain error.
rc=0
es_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-ids.md 99 "$id_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$es_err" == "task 99 not found in plan-ids.md (no heading matching 'Task 99')" ]]; then
pass "a missing task in a plan with Task headings gets only the not-found line"
else
fail "a missing task in a plan with Task headings gets only the not-found line"
echo " exit: $rc"
echo " stderr: $es_err"
fi
# --- An unclosed fence hides every later Task heading (#2436) ---
cat > "$repo/plan-unclosed.md" <<'PLAN'
# Example Plan
### Task 1: First task
```typescript
const x = 1
```
```typescript
const y = 2
### Task 2: Second task
TASK-2-MARKER
### Task 3: Third task
TASK-3-MARKER
PLAN
local fence_out="$TEST_ROOT/unclosed-brief.md" fence_err
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-unclosed.md 1 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 4 && ! -e "$fence_out" && "$fence_err" == *"line 9"*"never closes"* ]]; then
pass "task-brief refuses a brief that an unclosed fence would run to EOF (exit 4, names the line)"
else
fail "task-brief refuses a brief that an unclosed fence would run to EOF (exit 4, names the line)"
echo " exit: $rc"
echo " stderr: $fence_err"
echo " brief: $(cat "$fence_out" 2>/dev/null)"
fi
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-unclosed.md 2 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$fence_err" == *"never closes"* ]]; then
pass "task-brief names the unclosed fence when it hides the requested heading"
else
fail "task-brief names the unclosed fence when it hides the requested heading"
echo " exit: $rc"
echo " stderr: $fence_err"
fi
# An unclosed fence in a later task does not touch an earlier task's brief.
sed 's/^### Task 1: First task$/### Task 0: Before/' "$repo/plan-unclosed.md" \
| sed '1a\
\
### Task 1: Clean\
\
CLEAN-MARKER' > "$repo/plan-unclosed-later.md"
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-unclosed-later.md 1 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 0 && -z "$fence_err" ]] && grep -q CLEAN-MARKER "$fence_out" && ! grep -q 'Task 0' "$fence_out"; then
pass "an unclosed fence in a later task leaves an earlier task's brief alone"
else
fail "an unclosed fence in a later task leaves an earlier task's brief alone"
echo " exit: $rc"
echo " stderr: $fence_err"
echo " brief: $(cat "$fence_out" 2>/dev/null)"
fi
# A stray fence that hides no Task heading (seen in real plans as a lone
# ``` on the last line) leaves the brief complete: brief it, and warn.
cat > "$repo/plan-stray-fence.md" <<'PLAN'
### Task 1: First
BODY-1
### Task 2: Last
BODY-2
```
PLAN
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-stray-fence.md 2 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 0 && "$fence_err" == *"warning"*"line 8"*"never closes"* ]] \
&& grep -q BODY-2 "$fence_out" && ! grep -q BODY-1 "$fence_out"; then
pass "a stray fence that hides no Task heading briefs the task and warns"
else
fail "a stray fence that hides no Task heading briefs the task and warns"
echo " exit: $rc"
echo " stderr: $fence_err"
echo " brief: $(cat "$fence_out" 2>/dev/null)"
fi
# An unclosed fence that hides only some later prose, but no Task
# heading, also leaves the last task's brief complete.
printf '### Task 1: Only\n\nBODY-1\n\n```sh\necho hi\n\n## Notes\n\nNOT-A-TASK\n' > "$repo/plan-stray-prose.md"
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-stray-prose.md 1 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 0 && "$fence_err" == *"warning"* ]] && grep -q BODY-1 "$fence_out"; then
pass "an unclosed fence that hides no Task heading does not block the brief"
else
fail "an unclosed fence that hides no Task heading does not block the brief"
echo " exit: $rc"
echo " stderr: $fence_err"
fi
# When the open fence hides every Task heading, the fence is the
# diagnosis: the plan's English Task headings must not also draw the
# "use the English word Task" hint, which would contradict it.
printf '## Phase 1: Setup\n\n```sh\necho hi\n\n### Task 1: Hidden\n\nBODY-1\n' > "$repo/plan-fence-hides-all.md"
rc=0
fence_err="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan-fence-hides-all.md 1 "$fence_out" 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$fence_err" == *"line 3"*"never closes"* && "$fence_err" == *"task 1 not found"* \
&& "$fence_err" != *"English word"* ]]; then
pass "a fence hiding every Task heading gets the fence message, not the English-word hint"
else
fail "a fence hiding every Task heading gets the fence message, not the English-word hint"
echo " exit: $rc"
echo " stderr: $fence_err"
fi
# --- review-package takes the plan first and lands in its directory ---
local git_id=(-c user.email=t@example.com -c user.name=t -c commit.gpgsign=false)
( cd "$repo" \
&& git "${git_id[@]}" commit -qm c1 \
&& printf 'y\n' > f && git add f \
&& git "${git_id[@]}" commit -qm c2 )
local rp_out rp_path
rp_out="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md HEAD~1 HEAD)"
rp_path="$(printf '%s\n' "$rp_out" | sed -n 's/^wrote \(.*\): [0-9].*$/\1/p')"
case "$rp_path" in
"$repo/.superpowers/sdd/plan-a/review-"*.diff)
pass "review-package writes its diff under the plan's workspace" ;;
*)
fail "review-package writes its diff under the plan's workspace"
echo " got: $rp_path"
;;
esac
rc=0
(cd "$repo" && "$SDD_SCRIPTS/review-package" HEAD~1 HEAD >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 2 ]]; then
pass "review-package without a plan errors with exit 2"
else
fail "review-package without a plan errors with exit 2"
echo " exit: $rc"
fi
local rp_explicit
rp_explicit="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md HEAD~1 HEAD "$TEST_ROOT/explicit.diff")"
if [[ -s "$TEST_ROOT/explicit.diff" && "$rp_explicit" == *"$TEST_ROOT/explicit.diff"* ]]; then
pass "review-package honors an explicit OUTFILE"
else
fail "review-package honors an explicit OUTFILE"
echo " got: $rp_explicit"
fi
# --- range guards: BASE must be an ancestor of HEAD, range must be non-empty ---
local divergent
divergent="$(cd "$repo" && git "${git_id[@]}" commit-tree 'HEAD~1^{tree}' -p 'HEAD~1' -m divergent)"
rc=0
local guard_err
guard_err="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md "$divergent" HEAD 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$guard_err" == *"not a descendant"* ]]; then
pass "review-package rejects a BASE that is not an ancestor of HEAD with exit 3"
else
fail "review-package rejects a BASE that is not an ancestor of HEAD with exit 3"
echo " exit: $rc"
echo " stderr: $guard_err"
fi
rc=0
guard_err="$(cd "$repo" && "$SDD_SCRIPTS/review-package" plan-a.md HEAD HEAD 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 3 && "$guard_err" == *"empty commit range"* ]]; then
pass "review-package rejects an empty BASE..HEAD range with exit 3"
else
fail "review-package rejects an empty BASE..HEAD range with exit 3"
echo " exit: $rc"
echo " stderr: $guard_err"
fi
# --- Worktree isolation: a linked worktree resolves its own workspace ---
local wt="$TEST_ROOT/wt"
( cd "$repo" && git worktree add -q "$wt" -b wt-feature )
local wt_root wt_dir
wt_root="$(cd "$wt" && git rev-parse --show-toplevel)"
wt_root="$(physical_path "$wt_root")"
wt_dir="$(cd "$wt" && "$SDD_SCRIPTS/sdd-workspace" plan-a.md)"
if [[ "$wt_dir" == "$wt_root/.superpowers/sdd/plan-a" && "$wt_dir" != "$dir_a" ]]; then
pass "linked worktree resolves its own distinct workspace"
else
fail "linked worktree resolves its own distinct workspace"
echo " main: $dir_a"
echo " wt: $wt_dir"
fi
printf 'y\n' > "$wt_dir/artifact.md"
local wt_status
wt_status="$(cd "$wt" && git status --porcelain)"
if [[ "$wt_status" != *".superpowers"* ]]; then
pass "worktree workspace invisible to git status"
else
fail "worktree workspace invisible to git status"
echo " status: $wt_status"
fi
# --- Which repository: cwd, then -C, then the plan's (#2429, #1799) ---
printf 'wt-only\n' > "$wt/wt-only.txt"
( cd "$wt" && git add wt-only.txt && git "${git_id[@]}" commit -qm wt-change )
local wt_base wt_head
wt_base="$(cd "$wt" && git rev-parse HEAD~1)"
wt_head="$(cd "$wt" && git rev-parse HEAD)"
# An executor working in the worktree with an absolute path to the main
# checkout's plan (writing-plans leaves the plan uncommitted there) keeps
# its workspace in the worktree it is working in.
printf '# Main only\n\n## Task 1: Main only\n\nMain only.\n' > "$repo/main-only.md"
local wt_abs_dir
wt_abs_dir="$(cd "$wt" && "$SDD_SCRIPTS/sdd-workspace" "$repo/main-only.md")" || true
if [[ "$wt_abs_dir" == "$wt_root/.superpowers/sdd/main-only" ]]; then
pass "a plan in another worktree still resolves to the current worktree's workspace"
else
fail "a plan in another worktree still resolves to the current worktree's workspace"
echo " got: $wt_abs_dir"
fi
# -C DIR runs as if started in DIR: workspace and git commands both.
local c_dir
c_dir="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" -C "$wt" plan-a.md)" || true
if [[ "$c_dir" == "$wt_root/.superpowers/sdd/plan-a" ]]; then
pass "sdd-workspace -C DIR resolves DIR's workspace"
else
fail "sdd-workspace -C DIR resolves DIR's workspace"
echo " got: $c_dir"
fi
# These two run the way SKILL.md invokes them, `bash scripts/...` from the
# skill's directory: the relative script path must survive the -C cd.
local c_brief
c_brief="$(cd "$SDD_SCRIPTS/.." && bash scripts/task-brief -C "$wt" plan-a.md 1)" || true
if [[ "$c_brief" == "wrote $wt_root/.superpowers/sdd/plan-a/task-1-brief.md: "* ]]; then
pass "task-brief -C DIR writes the brief into DIR's workspace"
else
fail "task-brief -C DIR writes the brief into DIR's workspace"
echo " got: $c_brief"
fi
local c_rp c_rp_path
c_rp="$(cd "$SDD_SCRIPTS/.." && bash scripts/review-package -C "$wt" plan-a.md "$wt_base" HEAD)" || true
c_rp_path="$(printf '%s\n' "$c_rp" | sed -n 's/^wrote \(.*\): [0-9].*$/\1/p')"
case "$c_rp_path" in
"$wt_root/.superpowers/sdd/plan-a/review-"*.diff)
if grep -q 'wt-only.txt' "$c_rp_path"; then
pass "review-package -C DIR diffs DIR's HEAD into DIR's workspace"
else
fail "review-package -C DIR diffs DIR's HEAD into DIR's workspace"
echo " diff lacks the worktree's commit: $c_rp_path"
fi
;;
*)
fail "review-package -C DIR diffs DIR's HEAD into DIR's workspace"
echo " got: $c_rp"
;;
esac
rc=0
(cd "$repo" && "$SDD_SCRIPTS/review-package" -C "$TEST_ROOT/no-such-dir" plan-a.md HEAD~1 HEAD >/dev/null 2>&1) || rc=$?
if [[ "$rc" -eq 2 ]]; then
pass "review-package -C with a missing directory errors with exit 2"
else
fail "review-package -C with a missing directory errors with exit 2"
echo " exit: $rc"
fi
# Run from outside any repository (e.g. the skill's own directory in an
# installed plugin), the scripts stop even when the plan's absolute path
# is inside a repository: like git, they act on the current directory's
# working tree (or -C DIR), never on one guessed from the plan.
local nonrepo="$TEST_ROOT/not-a-repo"
mkdir -p "$nonrepo"
local nr_msg="SDD scripts must run from inside the git working tree you're executing in, with at least one commit (current directory: $nonrepo). If this is a new project, run 'git init' and make a first commit, then rerun."
local nr_before nr_cmd nr_err
nr_before="$(find "$wt_root/.superpowers" | sort)"
for nr_cmd in "sdd-workspace $wt/plan-a.md" "task-brief $wt/plan-a.md 1" "review-package $wt/plan-a.md $wt_base $wt_head"; do
rc=0
# shellcheck disable=SC2086 # nr_cmd is a fixed script name plus its arguments
nr_err="$(cd "$nonrepo" && "$SDD_SCRIPTS"/$nr_cmd 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 2 && "$nr_err" == "$nr_msg"$'\n'"git said: fatal: not a git repository"* ]]; then
pass "${nr_cmd%% *} outside any repository stops with the shared message despite a plan in a repository"
else
fail "${nr_cmd%% *} outside any repository stops with the shared message despite a plan in a repository"
echo " exit: $rc"
echo " stderr: $nr_err"
fi
done
if [[ ! -e "$nonrepo/.superpowers" && "$(find "$wt_root/.superpowers" | sort)" == "$nr_before" ]]; then
pass "outside any repository, nothing is written to the cwd or the plan's repository"
else
fail "outside any repository, nothing is written to the cwd or the plan's repository"
fi
# --- No repository anywhere: a greenfield plan before Task 1 (#2242) ---
local gf="$TEST_ROOT/greenfield"
mkdir -p "$gf"
printf '## Task 1: Scaffold the repo\n\nCreate files.\n' > "$gf/plan.md"
# One message for both ways to get here: a caller standing in the wrong
# directory (such as the plugin's own skill directory, where git init is
# the wrong fix) and a new project with no repository yet. git's own
# first error line follows it, so the reason git refused is never hidden.
local no_repo_msg="SDD scripts must run from inside the git working tree you're executing in, with at least one commit (current directory: $gf). If this is a new project, run 'git init' and make a first commit, then rerun."
local cmd gf_err
for cmd in "sdd-workspace plan.md" "task-brief plan.md 1"; do
local script=${cmd%% *}
rc=0
# shellcheck disable=SC2086 # cmd is a fixed script name plus its arguments
gf_err="$(cd "$gf" && "$SDD_SCRIPTS"/$cmd 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 2 && "$gf_err" == "$no_repo_msg"$'\n'"git said: fatal: not a git repository"* ]]; then
pass "$script outside any repository exits 2 naming both fixes"
else
fail "$script outside any repository exits 2 naming both fixes"
echo " exit: $rc"
echo " stderr: $gf_err"
fi
done
rc=0
gf_err="$(cd "$gf" && "$SDD_SCRIPTS/review-package" plan.md HEAD~1 HEAD 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 2 && "$gf_err" == "$no_repo_msg"$'\n'"git said: fatal: not a git repository"* ]]; then
pass "review-package outside any repository exits 2 naming both fixes"
else
fail "review-package outside any repository exits 2 naming both fixes"
echo " exit: $rc"
echo " stderr: $gf_err"
fi
if [[ ! -e "$gf/.superpowers" ]]; then
pass "nothing is written outside a repository"
else
fail "nothing is written outside a repository"
find "$gf/.superpowers" | sed 's/^/ /'
fi
# A repository with no commit yet has no range to review, so
# review-package gets the same stop, naming its directory.
git init -q -b main "$gf"
rc=0
gf_err="$(cd "$gf" && "$SDD_SCRIPTS/review-package" plan.md HEAD~1 HEAD 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 2 && "$gf_err" == "$no_repo_msg"$'\n'"git said: fatal: "* && ! -e "$gf/.superpowers" ]]; then
pass "review-package in a repository with no commit exits 2 with the same message"
else
fail "review-package in a repository with no commit exits 2 with the same message"
echo " exit: $rc"
echo " stderr: $gf_err"
fi
# --- git refuses the repository itself: its reason must reach the caller ---
# Inside a working tree git won't trust ("dubious ownership": another
# owner, a FAT or network drive, WSL /mnt/c), the shared message alone
# would be wrong, so git's own line has to follow it. git's test knob
# GIT_TEST_ASSUME_DIFFERENT_OWNER simulates another owner without root.
local dub_err dub_msg="SDD scripts must run from inside the git working tree you're executing in, with at least one commit (current directory: $repo). If this is a new project, run 'git init' and make a first commit, then rerun."
if (cd "$repo" && GIT_TEST_ASSUME_DIFFERENT_OWNER=1 git rev-parse --show-toplevel >/dev/null 2>&1); then
echo " [SKIP] git refusing a dubious-ownership repo ($(git --version) ignores GIT_TEST_ASSUME_DIFFERENT_OWNER)"
else
rc=0
dub_err="$(cd "$repo" && GIT_TEST_ASSUME_DIFFERENT_OWNER=1 "$SDD_SCRIPTS/sdd-workspace" plan-a.md 2>&1 >/dev/null)" || rc=$?
if [[ "$rc" -eq 2 && "$dub_err" == "$dub_msg"$'\n'"git said: fatal: detected dubious ownership in repository at "* ]]; then
pass "a repository git refuses as dubious stops with the shared message plus git's reason"
else
fail "a repository git refuses as dubious stops with the shared message plus git's reason"
echo " exit: $rc"
echo " stderr: $dub_err"
fi
fi
# --- helpers survive a mode-stripping extractor dropping exec bits (#2040) ---
local stripped="$TEST_ROOT/stripped-scripts"
mkdir -p "$stripped"
cp "$SDD_SCRIPTS/sdd-repo" "$SDD_SCRIPTS/sdd-workspace" "$SDD_SCRIPTS/task-brief" "$SDD_SCRIPTS/review-package" "$stripped/"
chmod -x "$stripped"/*
local noexec_out noexec_rc=0
noexec_out="$(cd "$repo" && bash "$stripped/task-brief" plan-b.md 1 2>&1)" || noexec_rc=$?
if [[ "$noexec_rc" -eq 0 && -f "$repo/.superpowers/sdd/plan-b/task-1-brief.md" ]]; then
pass "task-brief works with no exec bit on sdd-workspace"
else
fail "task-brief works with no exec bit on sdd-workspace"
echo " rc: $noexec_rc"
echo " output: $noexec_out"
fi
# --- Ownership markers: two plans with the same basename (#2045) ---
mkdir -p "$repo/docs/alpha" "$repo/docs/beta"
cat > "$repo/docs/alpha/plan.md" <<'PLAN'
# Alpha Plan
## Task 1: Alpha work
Alpha-only requirement text.
PLAN
cat > "$repo/docs/beta/plan.md" <<'PLAN'
# Beta Plan
## Task 1: Beta work
Beta-only requirement text.
PLAN
local dir_alpha dir_beta
dir_alpha="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/alpha/plan.md)"
dir_beta="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/beta/plan.md)"
if [[ "$dir_alpha" != "$dir_beta" ]]; then
pass "same-basename plans resolve to distinct workspaces"
else
fail "same-basename plans resolve to distinct workspaces"
echo " alpha: $dir_alpha"
echo " beta: $dir_beta"
fi
( cd "$repo" && "$SDD_SCRIPTS/task-brief" docs/alpha/plan.md 1 >/dev/null )
( cd "$repo" && "$SDD_SCRIPTS/task-brief" docs/beta/plan.md 1 >/dev/null )
if grep -q "Alpha-only requirement text." "$dir_alpha/task-1-brief.md" 2>/dev/null \
&& grep -q "Beta-only requirement text." "$dir_beta/task-1-brief.md" 2>/dev/null; then
pass "same-basename plans keep both task briefs intact"
else
fail "same-basename plans keep both task briefs intact"
echo " alpha brief: $(cat "$dir_alpha/task-1-brief.md" 2>/dev/null)"
echo " beta brief: $(cat "$dir_beta/task-1-brief.md" 2>/dev/null)"
fi
# --- Legacy adoption: pre-existing workspace without a marker ---
printf '# Foo\n\n## Task 1: Foo\n\nFoo.\n' > "$repo/foo.md"
mkdir -p "$repo/.superpowers/sdd/foo"
printf 'ledger\n' > "$repo/.superpowers/sdd/foo/progress.md"
local dir_foo
dir_foo="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" foo.md)"
if [[ "$dir_foo" == "$repo/.superpowers/sdd/foo" \
&& -f "$dir_foo/progress.md" \
&& "$(cat "$dir_foo/plan-path" 2>/dev/null)" == "foo.md" ]]; then
pass "legacy markerless workspace is adopted in place and marked"
else
fail "legacy markerless workspace is adopted in place and marked"
echo " dir: $dir_foo"
echo " marker: $(cat "$dir_foo/plan-path" 2>/dev/null)"
fi
# --- Ownership conflict: marker names a different plan ---
printf '# Bar\n\n## Task 1: Bar\n\nBar.\n' > "$repo/bar.md"
mkdir -p "$repo/.superpowers/sdd/bar"
printf 'somewhere-else/bar.md\n' > "$repo/.superpowers/sdd/bar/plan-path"
printf 'other ledger\n' > "$repo/.superpowers/sdd/bar/progress.md"
local dir_bar
dir_bar="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" bar.md)"
if [[ "$dir_bar" == "$repo/.superpowers/sdd/bar-repo" \
&& "$(cat "$dir_bar/plan-path" 2>/dev/null)" == "bar.md" ]]; then
pass "owned workspace disambiguates with parent-dir suffix"
else
fail "owned workspace disambiguates with parent-dir suffix"
echo " got: $dir_bar"
fi
if [[ "$(cat "$repo/.superpowers/sdd/bar/plan-path")" == "somewhere-else/bar.md" \
&& "$(cat "$repo/.superpowers/sdd/bar/progress.md")" == "other ledger" ]]; then
pass "conflicting plan leaves the original workspace untouched"
else
fail "conflicting plan leaves the original workspace untouched"
fi
# --- Counter fallback: parent-suffixed workspace is owned too ---
printf '# Baz\n\n## Task 1: Baz\n\nBaz.\n' > "$repo/baz.md"
mkdir -p "$repo/.superpowers/sdd/baz" "$repo/.superpowers/sdd/baz-repo"
printf 'one/baz.md\n' > "$repo/.superpowers/sdd/baz/plan-path"
printf 'two/baz.md\n' > "$repo/.superpowers/sdd/baz-repo/plan-path"
local dir_baz
dir_baz="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" baz.md)"
if [[ "$dir_baz" == "$repo/.superpowers/sdd/baz-repo-2" \
&& "$(cat "$dir_baz/plan-path" 2>/dev/null)" == "baz.md" ]]; then
pass "double conflict falls back to a counter suffix"
else
fail "double conflict falls back to a counter suffix"
echo " got: $dir_baz"
fi
# --- Same plan spelled differently resolves to one workspace ---
local dir_rel dir_abs dir_dotdot
dir_rel="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" docs/alpha/plan.md)"
dir_abs="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" "$repo/docs/alpha/plan.md")"
dir_dotdot="$(cd "$repo/docs/beta" && "$SDD_SCRIPTS/sdd-workspace" ../alpha/plan.md)"
if [[ "$dir_rel" == "$dir_abs" && "$dir_rel" == "$dir_dotdot" \
&& "$(cat "$dir_rel/plan-path" 2>/dev/null)" == "docs/alpha/plan.md" ]]; then
pass "relative, absolute, and ../ spellings share one workspace and marker"
else
fail "relative, absolute, and ../ spellings share one workspace and marker"
echo " rel: $dir_rel"
echo " abs: $dir_abs"
echo " dotdot: $dir_dotdot"
echo " marker: $(cat "$dir_rel/plan-path" 2>/dev/null)"
fi
# --- Out-of-repo plans keep working, marker holds the absolute path ---
mkdir -p "$TEST_ROOT/outside"
printf '# Remote\n\n## Task 1: Remote\n\nRemote.\n' > "$TEST_ROOT/outside/remote-plan.md"
local outside_abs dir_out
outside_abs="$(cd "$TEST_ROOT/outside" && pwd -P)/remote-plan.md"
dir_out="$(cd "$repo" && "$SDD_SCRIPTS/sdd-workspace" "$TEST_ROOT/outside/remote-plan.md")"
if [[ "$dir_out" == "$repo/.superpowers/sdd/remote-plan" \
&& "$(cat "$dir_out/plan-path" 2>/dev/null)" == "$outside_abs" ]]; then
pass "out-of-repo plan gets a basename slug and an absolute-path marker"
else
fail "out-of-repo plan gets a basename slug and an absolute-path marker"
echo " dir: $dir_out"
echo " marker: $(cat "$dir_out/plan-path" 2>/dev/null)"
fi
# --- A repo's own committed .superpowers/sdd/.gitignore is left alone ---
git init -q -b main "$TEST_ROOT/own-ignore"
local own own_ignore
own="$(cd "$TEST_ROOT/own-ignore" && git rev-parse --show-toplevel)"
own_ignore=$'*\n!.gitignore\n!*/\n!*/progress.md'
mkdir -p "$own/.superpowers/sdd"
printf '%s\n' "$own_ignore" > "$own/.superpowers/sdd/.gitignore"
printf '# Plan\n\n## Task 1: One\n\nOne.\n' > "$own/plan.md"
(cd "$own" && git add -A && git -c user.name=t -c user.email=t@t commit -qm init)
(cd "$own" && "$SDD_SCRIPTS/sdd-workspace" plan.md >/dev/null)
if [[ "$(cat "$own/.superpowers/sdd/.gitignore")" == "$own_ignore" \
&& -z "$(cd "$own" && git status --porcelain -- .superpowers/sdd/.gitignore)" ]]; then
pass "an existing .superpowers/sdd/.gitignore is not overwritten"
else
fail "an existing .superpowers/sdd/.gitignore is not overwritten"
echo " now: $(cat "$own/.superpowers/sdd/.gitignore")"
fi
echo ""
if [[ "$FAILURES" -ne 0 ]]; then
echo "FAILED: $FAILURES assertion(s)."
exit 1
fi
echo "PASS"
}
main "$@"
|